Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WordSeparator and WordSplitter traits to separate modules #368

Merged
merged 2 commits into from
May 30, 2021
Merged

Move WordSeparator and WordSplitter traits to separate modules #368

merged 2 commits into from
May 30, 2021

Conversation

mgeisler
Copy link
Owner

The three main traits now all have their own module, and the core module is much slimmer:

  • wrap_algorithms is for the WrapAlgorithm trait as well as the wrap_first_fit and wrap_optimal_fit functions.
  • word_separators is for the WordSeparator trait.
  • word_splitters is for the WordSplitter trait and the split_words helper function.

@mgeisler mgeisler changed the title Move traits to separate modules Move WordSeparator and WordSplitter traits to separate modules May 30, 2021
@mgeisler
Move WordSeparator and implementing structs to a module
fb3691c 
This moves the `WordSeparator` trait and its implementations from the
root of the crate to a dedicated module. This way, the crate root
becomes less crowded and the module name can serve as a namespace.
@mgeisler
Move WordSplitter and split_words to new word_splitters module
f46fe0e 
This moves all “word splitting” or “hyphenation” functionality into
its own module. The three main traits now all have their own module,
and the `core` module is much slimmer.
@mgeisler mgeisler merged commit c66ed13 into master May 30, 2021
@mgeisler mgeisler deleted the modules branch May 30, 2021 13:57
@github-actions github-actions bot mentioned this pull request May 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgeisler