Simplify CI, drop Rust 1.31 compatibility #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the matrix configuration which allowed breakage on nightly -- I don't think I've ever seen nightly Rust break my crate. Even if it did, I would like to know about it and try and fix it. Caching is removed to prevent accidentally hiding problems when our dependencies release new versions. Finally, the --verbose flag adds precise version information to the log files. This has not been useful so far, so I'm removing it.
Over the years, we’ve repeatedly seen build failures in our CI, even when nothing changed in `textwrap`. The failures happened because we tested against a fixed version of Rust, but our dependencies kept releasing new patch it has versions that would push up the minimum required Rust version. The build failures makes it infeasible to keep `textwrap` compatible with any particular version of Rust. We will therefore track the latest stable version of Rust from now on.
The --verbose flag seems to mostly make the output unreadable and has thus been removed. The caching might have made things faster, but it increases the risk of us failing to spot problems when our dependencies are updated. Putting the "cargo build" into the install script means that Travis will hide the output by default. This lets us focus on the tests.
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 93.73% 94.02% +0.28%
==========================================
Files 4 4
Lines 383 368 -15
==========================================
- Hits 359 346 -13
+ Misses 24 22 -2
Continue to review full report at Codecov.
|
mgeisler
added a commit
that referenced
this pull request
Jun 12, 2022
This our current minimum supported Rust version (MSRV). I gave up on maintaining compatibility with Rust 2018 two years ago in #180, but I hope the update speed of our dependencies has slowed down enough that we can keep compatibility with Rust 1.56 for a while. If this turns out to be problematic again, then I will bump the MSRV as needed. This will of course be clearly communicated in the release notes for each release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the CI scripts and most importantly, this removes the test against a fixed version of Rust.
Over the years, we’ve repeatedly seen build failures in our CI, even when nothing changed in
textwrap. The failures happened because we tested against a fixed version of Rust, but our dependencies kept releasing new patch it has versions that would push up the minimum required Rust version.The build failures makes it infeasible to keep
textwrapcompatible with any particular version of Rust. We will therefore track the latest stable version of Rust from now on.