Skip to content

[gfx1151] flash_attn_triton_amd: enable in-thread transpose #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgehre-amd wants to merge 1 commit into from
Closed

[gfx1151] flash_attn_triton_amd: enable in-thread transpose #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions aiter/ops/triton/_triton_kernels/flash_attn_triton_amd/fwd_prefill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import torch
import triton
import triton.language as tl
from triton import knobs
from typing import Literal, Optional
from .common import compute_alibi_block, compute_fp8_scaling_factors, apply_rotary
from .utils import (
Expand All @@ -14,6 +15,15 @@
remap_xcd,
)

# gfx1151 (Strix Halo / RDNA3.5): enable Triton's in-thread transpose for the
# prefill FMHA kernels. It is only enabled by default for gfx1151 on Triton's
# main branch (the upcoming 3.8); the Triton version in use here still gates it
# to gfx942, so enable it explicitly. It is a consistent win (e.g. ~11% faster
# on ViT-style d=72, sq=sk>=3200 shapes). Only set it when the user has not made
# an explicit choice via TRITON_HIP_USE_IN_THREAD_TRANSPOSE.
if knobs.amd.use_in_thread_transpose is None and get_arch().name == "gfx1151":
knobs.amd.use_in_thread_transpose = True

FWD_PREFILL_AUTOTUNE_KEYS = [
"IS_CAUSAL",
"dropout_p",
Expand Down