Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tests in the test/utils.go file #930

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: enable tests in the test/utils.go file #930

merged 1 commit into from
Dec 2, 2023

Conversation

alexandear
Copy link
Contributor

This PR renames test/utils.go to test/utils_test.go to enable two tests contained in the utils.go.

Before PR's change:

❯ go test -v ./test/... | grep -E '(TestLintName|TestLine)'
=== RUN   TestLineLengthLimit
--- PASS: TestLineLengthLimit (0.00s)

After:

❯ go test -v ./test/... | grep -E '(TestLintName|TestLine)'
=== RUN   TestLineLengthLimit
--- PASS: TestLineLengthLimit (0.00s)
=== RUN   TestLine
--- PASS: TestLine (0.00s)
=== RUN   TestLintName
--- PASS: TestLintName (0.00s)

@mgechev
Copy link
Owner

mgechev commented Dec 2, 2023

Looks like there are some conflicts. Could you rebase?

@alexandear
Copy link
Contributor Author

@mgechev rebased

@chavacava chavacava merged commit 2a1701a into mgechev:master Dec 2, 2023
4 checks passed
@chavacava
Copy link
Collaborator

Thank you @alexandear

@alexandear alexandear deleted the test-enable-utils-test branch December 2, 2023 19:25
mfederowicz pushed a commit to mfederowicz/revive that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants