feat: add rule for redundant import alias

[damif94]

PR for issue #853

A new rule redundant-import-alias that would warn upon redundant import aliases, i.e., when the imported package name matches the alias names.

[chavacava]

Hi, thanks for the rule idea and its PR!
I've left some comments, please let me know what do you think about them.

[damif94]

Hi, thanks for the rule idea and its PR! I've left some comments, please let me know what do you think about them.

I agree with your suggestions, "redundant" seems like more appropriate. I already did the changes.

What's your view on making this rule as default? It seems like a pretty unquestionable linting rule, but on the other hand I got fear of retrocompatibility on upgrading versions and not sure on what's the project policies on upgrades.

[chavacava]

Hi, thanks for the rule idea and its PR! I've left some comments, please let me know what do you think about them.

I agree with your suggestions, "redundant" seems like more appropriate. I already did the changes.

What's your view on making this rule as default? It seems like a pretty unquestionable linting rule, but on the other hand I got fear of retrocompatibility on upgrading versions and not sure on what's the project policies on upgrades.

Thanks for the modifications.
About making this rule default: historically, revive default rules were those of golint. I propose to let the new rule out of the defaults and actvite it through the config.

[chavacava]

Thanks @damif94 !