New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused parameter in unexported function #1096

Merged

chavacava merged 1 commit into mgechev:master from alexandear:chore/remove-unused-parameter

Nov 7, 2024

Contributor

alexandear commented Nov 4, 2024

The PR removes unused parameter in the stringFormatSubrule.generateFailure unexported function to fix the warning:

❯ revive -config revive.toml ./...
rule/string-format.go:310:47: parameter 's' seems to be unused, consider removing or renaming it as _


          refactor: remove unused parameter in unexported function

6bf1f59

alexandear mentioned this pull request

chore: enable test shuffle and fix test #1097

Merged

chavacava merged commit 2ae6829 into mgechev:master

4 checks passed

alexandear deleted the chore/remove-unused-parameter branch

November 14, 2024 16:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet