Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use "path/filepath" instead of "path" #1073

Merged
merged 1 commit into from
Oct 25, 2024
Merged

refactor: use "path/filepath" instead of "path" #1073

merged 1 commit into from
Oct 25, 2024

Conversation

alexandear
Copy link
Contributor

The PR replaces the usages of path package with path/filepath.

Because path.Join is for URL paths, and filepath.Join is for file paths.

@denisvmedia denisvmedia merged commit 662e02c into mgechev:master Oct 25, 2024
4 checks passed
@alexandear alexandear deleted the refactor/use-filepath branch October 25, 2024 09:58
@alexandear alexandear mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @ccoVeille @denisvmedia