Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upperCaseConst to var-naming #851

Closed
comdiv opened this issue Jul 17, 2023 · 1 comment · Fixed by #852
Closed

Add upperCaseConst to var-naming #851

comdiv opened this issue Jul 17, 2023 · 1 comment · Fixed by #852

Comments

@comdiv
Copy link
Contributor

comdiv commented Jul 17, 2023

In our team naming policy we allow SUCH_NAMES for constants, (but not vars or functions), but now we cannot express it in revive
@comdiv comdiv changed the title Add allowUppercaseForConst to var-naming Add upperCaseConst to var-naming Jul 17, 2023
comdiv added a commit to comdiv/revive that referenced this issue Jul 17, 2023
@comdiv
imporve var-naming - add upperCaseConst option to allow UPPER_CASED…
70fc88e 
… constants mgechev#851
@comdiv comdiv mentioned this issue Jul 17, 2023
Merged
comdiv added a commit to comdiv/revive that referenced this issue Jul 17, 2023
@comdiv
var-naming fix backward/TOML compatibility mgechev#851
9aef945
chavacava added a commit that referenced this issue Jul 31, 2023
@comdiv @chavacava
imporve var-naming - add upperCaseConst option to allow UPPER_CASED…
8941d19 
… constants #851 (#852)

* imporve `var-naming`  - add upperCaseConst  option to allow UPPER_CASED constants #851

Co-authored-by: chavacava <[email protected]>
@chavacava
Copy link
Collaborator

closed by #852

@fregin fregin mentioned this issue Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imporve var-naming - add upperCaseConst option to allow UPPER_CASED constants #851 comdiv/revive
2 participants
@comdiv @chavacava