-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component padding or margin set from code gets replaced #546
Comments
mgarin
added a commit
that referenced
this issue
Sep 25, 2019
- InsetsUIResource.java - Better `Insets` extension that is `UIResource` and can be cloned and merged - ComponentStyle.java, ComponentStyleConverter.java - Replaced `Insets` with `InsetsUIResource` - ComponentStyle.java, AbstractLayoutManager.java - Added workaround for layout constraints preservation Layout [ #545 ] - AbstractLayoutManager.java - Added API for migrating layout settings upon their replacement through styling system - AbstractLineLayout.java - Added migration capabilities MenuBar [ #545 ] - WMenuBarUI.java, - New optimized basic UI implementation - MenuBarLayout.java, StyleManager.java - Added `UIResource` implementation and XStream aliases - WebMenuBarUI.java - Removed layout definition, it will now be provided in style - menubar.xml - Added layout definition instead of one in `WebMenuBarUI` - menubar.xml - Added padding to make popup menu of first element fit into root pane bounds to use lightweight popup PopupMenu - popupmenu.xml - Slightly reduced shadow to have lesser overlap with functional elements and fit into root pane bounds in more cases StatusBar - StatusBarLayout.java, StyleManager.java - Added `UIResource` implementation and XStream aliases - WebStatusBar.java - Removed layout definition, it will now be provided in style - statusbar.xml - Added layout definition instead of one in `WebStatusBar` ToolBar - ToolbarLayout.java, StyleManager.java - Added `UIResource` implementation and XStream aliases - WebToolBarUI.java - Removed layout definition, it will now be provided in style - toolbar.xml - Added layout definition instead of one in `WebToolBarUI` - WebToolBar.java - Overridden missing basic `JToolBar` method for adding a sized separator TabbedPane - TabArea.java, TabContainer.java - Changed initial layout to `null` to allow it's provision through style Accordion - AccordionPane.java - Changed initial layout to `null` to allow it's provision through style Link [ #547 ] - WebLink.java - Fixed translation of `LinkAction` text if it is a language key Label - WebLabelUI.java - Added missing generics InterfaceInspector - InterfaceInspector.java - Added `VisibilityBehavior` to correctly hide inspected element when inspector is hidden - InterfaceInspector.java - Now requests focus for the tree when inspector tool have picked inspected target - InterfaceTree.java - Added `VisibilityBehavior` to disable all behaviors while tree is not visible - InterfaceTreeNode.java - Moved windows listener here from `InterfaceTreeDataProvider` - InterfaceTreeNodeComparator.java - Separated from `InterfaceTreeDataProvider` Utilities - TreeUtils.java - Tree state restore performance optimization - VisibilityBehavior.java - Updated API to provide tracked `Component` of generic type - VisibilityBehavior.java - Overridable methods are not abstract anymore so there is no need to override both if not necessary DemoApplication - AbstractTitledPreview.java - Simplified layout and component order - AbstractPreviewExample.java - Removed property listener usage that doesn't work correctly - ExamplesTreeNode.java - Refactored to avoid `null` parameters being passed - InspectorFrame.java - Removed now unnecessary deselection of inspected element - ResourceLocation.java - Removed unnecessary `Serializable` marker - demo-language.xml - Added missing popover basic example title
This have been fixed now and will be available in v1.2.11 update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a custom padding or margin is provided into any WebLaF component through their standard public API - they get replaced once component style or application skin changes.
This happens because skins provide non-
UIResource
insets as padding and margin and therefore being handled as a user-provided setting.The text was updated successfully, but these errors were encountered: