Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React 17.x to peerDependencies #916

Closed
maciejregula opened this issue Mar 3, 2021 · 1 comment
Closed

Add React 17.x to peerDependencies #916

maciejregula opened this issue Mar 3, 2021 · 1 comment

Comments

@maciejregula
Copy link

Hi,

When will React 17.x be added as peerDeependency?
When you have React 17.x and npm version 7 installed you need to install this pacakge with --force or --legacy-peer-deps flags, otherwise you get:

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR!   peer react@">=16.8.0" from @emotion/[email protected]
npm ERR!   node_modules/@emotion/react
npm ERR!     peerOptional @emotion/react@"^11.0.0" from [email protected]
npm ERR!     node_modules/styled-breakpoints
npm ERR!       styled-breakpoints@"*" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional react@"^16.8.0" from [email protected]
npm ERR! node_modules/styled-breakpoints
npm ERR!   styled-breakpoints@"*" from the root project

Thanks!

mg901 added a commit that referenced this issue Mar 3, 2021
BREAKING CHANGE: remove support for react below v17.x.x
github-actions bot pushed a commit that referenced this issue Mar 3, 2021
# [10.0.0](v9.0.12...v10.0.0) (2021-03-03)

### Bug Fixes

* **peer-deps:** replace react "^16.8.0" with  "^17.0.0" [[#916](https://github.com/mg901/styled-breakpoints/issues/916)](https://github.com/mg901/styled-breakpoints/issues/916) ([938dbff](938dbff))

### BREAKING CHANGES

* **peer-deps:** remove support for react below v17.x.x
@mg901
Copy link
Owner

mg901 commented Mar 3, 2021

@maciejregula, thank you! Done!

@mg901 mg901 closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants