-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types are incorrect and/or missing #1390
Labels
Comments
mg901
added a commit
that referenced
this issue
Jun 9, 2023
mg901
added a commit
that referenced
this issue
Jun 9, 2023
github-actions bot
pushed a commit
that referenced
this issue
Jun 9, 2023
# [12.1.0](v12.0.4...v12.1.0) (2023-06-09) ### Features * add strict types for default and custom media queries ([8794580](8794580)), closes [#1390](#1390)
Hi, @daviddelusenet. Sorry for my too long answer. Thank you for your feedback and for using this library. I appreciate your kind words and I'm glad to hear that it has been helpful to you. You could try to use I will be very glad to your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thanks for maintaining this library! One of the few that hasn't been left for death.
However, I've been running into some issues when using this package in a TypeScript project.
First of all, the
up
/down
/between
/only
function parameter is not strictly typed. It would be nice if the keys from thecreateTheme
object would be used here. Now this parameter is just of typestring
. However, I can still use the package fine without this strict typing.Another thing which is causing a bigger issue: the return value of the
up
/down
/between
/only
functions. At the moment that isany
, which causes an error when using these functions in combination withuseBreakpoint
:Let me know if you need any more information!
The text was updated successfully, but these errors were encountered: