Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep state in dataroom view between document and dataroom view #783 #968

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Nithin-532
Copy link
Contributor

@mfts Sorry my pr got deleted by mistake. I pushed the changes with new pr.

@Nithin-532 Nithin-532 requested a review from mfts as a code owner October 14, 2024 16:18
Copy link

vercel bot commented Oct 14, 2024

@Nithin-532 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I think it's a good solution to the problem. Good thinking using useMemo

I am wondering if in the next iteration, we can someone save the state of each folder (open/closed) and then accurately represent the state of a dataroom at each point. but that's a little more advanced

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 3:22am

@mfts mfts merged commit da2e0cc into mfts:main Oct 15, 2024
3 checks passed
Copy link

oss-gg bot commented Oct 15, 2024

Awarding Nithin-532: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/Nithin-532

@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@mfts
Copy link
Owner

mfts commented Oct 15, 2024

Congrats on your first contribution @Nithin-532 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants