Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

951-View dataroom folder tree list and documnet list ui fix #952

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

AshishViradiya153
Copy link
Contributor

fixes #951

Copy link

vercel bot commented Oct 14, 2024

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

what-the-diff bot commented Oct 14, 2024

PR Summary

  • Removal of Unused Import
    The unused import called useRouter from next/router has been removed. This makes the code cleaner and potentially enhances the performance.

  • Scrollbar Component Addition
    A scrollbar component is added to the DataroomViewer. This will enhance the data room viewer's scroll functionality and improve user navigation.

  • Layout Update For Sidebar and Content area

    • Padding and margin classes have been adjusted to enhance the layout and provide proper space between elements.
    • ViewFolderTree component is now wrapped inside the ScrollArea, allowing better handling of scrolling in the folder tree.
    • Horizontal scroll bars are included now for easier navigation across the folder tree.
  • Sheet Component Behavioural Enhancement
    Improvements were made to the Sheet component to make it more accessible and visually appealing.

  • Breadcrumb Implementation Optimization
    The breadcrumb implementation has been cleaned up and optimized, providing a much smoother user experience when navigating directories.

@AshishViradiya153 AshishViradiya153 changed the title Dataroom folder tree list and documnet list ui fix 951-Dataroom folder tree list and documnet list ui fix Oct 15, 2024
@AshishViradiya153 AshishViradiya153 changed the title 951-Dataroom folder tree list and documnet list ui fix 951-View dataroom folder tree list and documnet list ui fix Oct 16, 2024
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question about some duplicate components

components/view/DataroomViewer.tsx Outdated Show resolved Hide resolved
components/view/DataroomViewer.tsx Outdated Show resolved Hide resolved
@mfts mfts added revisit Currently not required but important in the future 🕹️ 150 points iteration-1 labels Oct 19, 2024
@AshishViradiya153
Copy link
Contributor Author

now perfect, @mfts recheck please
Thanks.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! looks great

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 11:53am

@mfts mfts removed revisit Currently not required but important in the future iteration-1 labels Oct 19, 2024
@mfts mfts merged commit c27f3f6 into mfts:main Oct 19, 2024
3 checks passed
Copy link

oss-gg bot commented Oct 19, 2024

Awarding AshishViradiya153: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/AshishViradiya153

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Dataroom view ui : hotFix
2 participants