Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the unscrollability across the /settings/branding page across navbar-and-frontpage #823

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

dhanyamd
Copy link
Contributor

The Problem :

on smaller devices on the branding page the preview of the navbar and frontpage doesn't seem to be scroll showing only half the full image that's displayed on larger devices

beforepp

it is unscrollable, doesnt let the user see the entire image

What does this PR do :

it fixes this problem and makes both the navbar and frontpage scrollable on smaller devices
users can effectively scroll across the image even on smaller devices enabling them to see the full pic

mm

afpp3

ps: couldn't capture a video because of my system but i assure this works

@dhanyamd dhanyamd requested a review from mfts as a code owner October 12, 2024 13:13
Copy link

vercel bot commented Oct 12, 2024

@dhanyamd is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 12, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dhanyamd
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dhanyamd
Copy link
Contributor Author

recheck

@dhanyamd
Copy link
Contributor Author

I have read the CLA Document and i hereby sign the CLA

@dhanyamd
Copy link
Contributor Author

recheck

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:09am

@mfts mfts changed the title Fix: the unscrollability across the /settings/branding page across navbar-and-frontpage fix: the unscrollability across the /settings/branding page across navbar-and-frontpage Oct 19, 2024
@mfts mfts merged commit 3620287 into mfts:main Oct 19, 2024
4 checks passed
Copy link

oss-gg bot commented Oct 19, 2024

Awarding dhanyamd: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/dhanyamd

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
@dhanyamd dhanyamd deleted the fix/responsiveness-branding branch October 19, 2024 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants