Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added last_used in login page #718

Merged
merged 7 commits into from
Oct 12, 2024
Merged

feat: added last_used in login page #718

merged 7 commits into from
Oct 12, 2024

Conversation

RajuGangitla
Copy link
Contributor

I added a last used text on login form and im using local storage the value

Fixes #707

screen-capture.22.webm

@RajuGangitla RajuGangitla requested a review from mfts as a code owner October 10, 2024 19:30
@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024

@RajuGangitla is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @Hitarthsheth07! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Hitarthsheth07 Hitarthsheth07 removed their assignment Oct 10, 2024
@RajuGangitla
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

Assigned to @himanjalsaha! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@himanjalsaha himanjalsaha removed their assignment Oct 11, 2024
@himanjalsaha
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

Assigned to @himanjalsaha! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Meetpidev
Copy link

I have read the CLA Document and I hereby sign the CLA
Hey Please tell me How to sign CLA ? i dont found any link for it in CLA.md

@RajuGangitla
Copy link
Contributor Author

Just comment that

mfts
mfts requested changes Oct 11, 2024
View reviewed changes
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more love on the last_used indicator.

perhaps something like this
CleanShot 2024-10-12 at 00 38 24@2x

components/hooks/useLastUsed.tsx Outdated
Comment on lines 31 to 35
export const LastUsed = ({ className }: { className?: string | undefined }) => {
return (
<span className={classNames("text-gray-500 absolute right-1 text-xs", className ?? "")}>{("last_used")}</span>
);
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we give the last used indicator a little more love :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a tool tip @mfts

Copy link

@Meetpidev Meetpidev Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfts we can make the UI better than present.. /assign

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will improve it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Meetpidev I'm already working on this issue

@RajuGangitla
Copy link
Contributor Author

image

@mfts improved the last used

@mfts
Copy link
Owner

mfts commented Oct 12, 2024

@RajuGangitla thanks a ton. last request, because we had a contribution on the sign up just earlier than you.

could you please merge in the current main branch and resolve any conflicts.

btw the design looks 🔥 now

@RajuGangitla
Copy link
Contributor Author

@mfts will do it one minute please wait

@RajuGangitla
Copy link
Contributor Author

@mfts done merged main branch

@mfts
Copy link
Owner

mfts commented Oct 12, 2024

@RajuGangitla you were faster than me 💪

I just merged in the login change to main. There's just one conflict left. Should be quick to fix.

Thanks again :)

@RajuGangitla
Copy link
Contributor Author

@mfts resolved

mfts
mfts approved these changes Oct 12, 2024
View reviewed changes
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend

giphy-5

@vercel Vercel
Copy link

vercel bot commented Oct 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 5:46am

@mfts
Copy link
Owner

mfts commented Oct 12, 2024

@RajuGangitla i guess not quite yet.

build error:

9:13  Error: Definition for rule '@calcom/eslint/avoid-web-storage' was not found.  @calcom/eslint/avoid-web-storage
19:13  Error: Definition for rule '@calcom/eslint/avoid-web-storage' was not found.  @calcom/eslint/avoid-web-storage
30:13  Error: Definition for rule '@calcom/eslint/avoid-web-storage' was not found.  @calcom/eslint/avoid-web-storage

@RajuGangitla
Copy link
Contributor Author

@mfts resolved that running the command npm run build .....

mfts
mfts reviewed Oct 12, 2024
View reviewed changes
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll just remove these

lib/webstorage.ts Outdated Show resolved Hide resolved
lib/webstorage.ts Outdated Show resolved Hide resolved
lib/webstorage.ts Outdated Show resolved Hide resolved
@mfts mfts merged commit 80299d2 into mfts:main Oct 12, 2024
2 checks passed
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

Awarding RajuGangitla: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/RajuGangitla

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfts mfts mfts approved these changes

@Meetpidev Meetpidev Meetpidev left review comments

Assignees

@himanjalsaha himanjalsaha

Labels
hacktoberfest 🕹️ oss.gg 🕹️ 300 points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🕹️] "Last Used" indicator on login page
5 participants
@RajuGangitla @himanjalsaha @Meetpidev @mfts @Hitarthsheth07