Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix-Dataroom-name-trim #700

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

AshishViradiya153
Copy link
Contributor

@AshishViradiya153 AshishViradiya153 commented Oct 9, 2024

Fixes #672
@mfts
HotFix: The DataRoom name value is trimmed to ensure smooth deletion. This trimming is applied during both the creation and update processes and needs to be pushed as soon as possible.

Copy link

vercel bot commented Oct 9, 2024

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's sanitize the dataroom name in the request body and not on the api side.

@AshishViradiya153
Copy link
Contributor Author

@mfts please recheck

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 4:12am

@mfts mfts merged commit 18070a5 into mfts:main Oct 10, 2024
3 checks passed
Copy link

oss-gg bot commented Oct 10, 2024

Awarding AshishViradiya153: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/AshishViradiya153

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Data Room Deletion: Title Mismatch Even with Same Title
2 participants