Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve document 📄 "Action" tab #678

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

AshishViradiya153
Copy link
Contributor

@AshishViradiya153 AshishViradiya153 commented Oct 7, 2024

Fixes #677

  • The user can create a data room using the "Action" tabs if they have the correct subscription; otherwise, an "Upgrade Plan" tab will be shown.
  • Display a tooltip for "Upload a new version." (The problem is that if we wrap the button with a tooltip, the button event doesn't work.)

image
image

Copy link

vercel bot commented Oct 7, 2024

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@AshishViradiya153
Copy link
Contributor Author

@mfts could you please review and let me know if there’s anything further needed from my side?

@mfts
Copy link
Owner

mfts commented Oct 9, 2024

@AshishViradiya153 I think we should hide the "add to dataroom" if the user is either on free or pro and not on trial

@AshishViradiya153
Copy link
Contributor Author

AshishViradiya153 commented Oct 9, 2024

@mfts "Add to Dataroom" is always there, which I think is great. If the user doesn't have a Dataroom, it will be hidden. Additionally, users can create a new Dataroom using the "Create Dataroom" option if they have the right plan; otherwise, an upgrade popup will appear.

image
here its shows create dataroom and add to dataroom, if dont have a subscription than it wil show upgrad plan tab.

/documents
image

@AshishViradiya153
Copy link
Contributor Author

@mfts Recheck please

@mfts
Copy link
Owner

mfts commented Oct 11, 2024

@AshishViradiya153 thanks. I still think it's confusing to have a "Create New Dataroom" on a document dropdown. It's out of context for most users.

  • Let's remove the "Create New Dataroom" option from the dropdowns altogether.
  • Hide the "Add to dataroom" when user doesn't have a dataroom

@AshishViradiya153
Copy link
Contributor Author

AshishViradiya153 commented Oct 12, 2024

@mfts Please recheck, I have removed the "Create New Dataroom" option and also hidden "datarooms" if there aren't any.

Thank you.

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:13am

@mfts mfts merged commit ab9dc5b into mfts:main Oct 13, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
@mfts
Copy link
Owner

mfts commented Oct 13, 2024

/award 150

@mfts
Copy link
Owner

mfts commented Oct 13, 2024

@AshishViradiya153 i think something went wrong with the award. could you please open an issue referencing this PR and then I award you there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Improve Document "Action" Tab
2 participants