Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

599-Add custome favicon icon in document link #608

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

AshishViradiya153
Copy link
Contributor

@AshishViradiya153 AshishViradiya153 commented Sep 22, 2024

PR CONTAINS

A new user-friendly UI is implemented for adding a favicon icon.
Users can upload an image with the allowed file types (.png, .jpg, .jpeg, .ico) with a maximum size of 1MB.
File validation ensures the proper size and file type are uploaded.
The uploaded favicon will be displayed in the browser's tab as the link icon.
Fixed 500 Favicon error.

Copy link

vercel bot commented Sep 22, 2024

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Sep 22, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@AshishViradiya153
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@AshishViradiya153 AshishViradiya153 changed the title Add custome favicon icon in document link 599-Add custome favicon icon in document link Sep 23, 2024
@mfts
Copy link
Owner

mfts commented Sep 23, 2024

Thanks @AshishViradiya153 will take a look today :)

@mfts mfts linked an issue Sep 23, 2024 that may be closed by this pull request
@mfts
Copy link
Owner

mfts commented Oct 2, 2024

@AshishViradiya153 are you taking part in oss.gg?

@AshishViradiya153
Copy link
Contributor Author

Hasto (Yes)

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshishViradiya153 Looks great!

Two things that would make it perfect:

  • merge in the current main branch so everything is up to date and no merge conflicts
  • merge the two prisma migrations into one

@AshishViradiya153
Copy link
Contributor Author

@mfts, I've merged the current main branch and combined the two Prisma migrations into one as requested. Everything is now up to date, and I've pushed the changes. Let me know if anything else is needed!

@AshishViradiya153
Copy link
Contributor Author

Thanks for review @mfts.

@mfts mfts merged commit b178d32 into mfts:main Oct 4, 2024
3 checks passed
Copy link

oss-gg bot commented Oct 4, 2024

Awarding AshishViradiya153: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/AshishViradiya153

@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make link favicon customizable
2 participants