-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
599-Add custome favicon icon in document link #608
Conversation
@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Thanks @AshishViradiya153 will take a look today :) |
@AshishViradiya153 are you taking part in oss.gg? |
Hasto (Yes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AshishViradiya153 Looks great!
Two things that would make it perfect:
- merge in the current
main
branch so everything is up to date and no merge conflicts - merge the two prisma migrations into one
@mfts, I've merged the current main branch and combined the two Prisma migrations into one as requested. Everything is now up to date, and I've pushed the changes. Let me know if anything else is needed! |
Thanks for review @mfts. |
Awarding AshishViradiya153: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/AshishViradiya153 |
PR CONTAINS
A new user-friendly UI is implemented for adding a favicon icon.
Users can upload an image with the allowed file types (.png, .jpg, .jpeg, .ico) with a maximum size of 1MB.
File validation ensures the proper size and file type are uploaded.
The uploaded favicon will be displayed in the browser's tab as the link icon.
Fixed 500 Favicon error.