Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataroom-users): create a new link for each invited group to datarooms #415

Merged
merged 1 commit into from
May 13, 2024

Conversation

mfts
Copy link
Owner

@mfts mfts commented May 13, 2024

No description provided.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 5:04pm

Copy link

what-the-diff bot commented May 13, 2024

PR Summary

  • Removal of 'links' Property
    Firstly, the 'links' property, which was earlier part of a database query, has been removed. This means, we no longer consider 'links' when fetching data from the database.

  • Creation of Unique Link for Invited Group
    Next, we made a change to enhance group invitation management. Every invited group will now get a unique link that is created specifically for them, instead of using a generic one. This link also has a property called 'enableFeedback' set to false, which means that initially, the group is not prompted to provide feedback.

  • Link ID Retrieval Update
    Following the previous change, we now retrieve a 'linkId' from the newly created unique link for each group, instead of using the first available dataroom link. This ensures that each group interacts with the dataroom via a link unique to them.

  • Updated Function Call for 'sendViewerInvitation'
    Lastly, the function 'sendViewerInvitation', responsible for inviting viewers to a dataroom, is now called with the updated 'linkId'. This revision ensures that the correct and unique link is used when inviting a group of viewers.

@mfts mfts merged commit 4c5fda7 into main May 13, 2024
2 checks passed
@mfts mfts deleted the fix/user-invite branch July 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant