Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(278) - document card pdf icon color #291

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix(278) - document card pdf icon color #291

merged 2 commits into from
Feb 29, 2024

Conversation

sachin-duhan
Copy link
Contributor

close #278

@sachin-duhan sachin-duhan requested a review from mfts as a code owner February 18, 2024 17:05
Copy link

vercel bot commented Feb 18, 2024

@sachin-duhan is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@ashrafchowdury
Copy link
Contributor

Hay @sachin-duhan, It would be great if you could share some screenshots of both dark and light themes of that icon.

@ashrafchowdury
Copy link
Contributor

This fix does not resolve the issue, we have to change the PDF icon file to fix the issue everywhere

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 5:32am

@mfts
Copy link
Owner

mfts commented Feb 29, 2024

Thanks for the fix @sachin-duhan 🎉

@mfts mfts merged commit 2c91a6d into mfts:main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF file icon is not visible on the light theme.
3 participants