feat: Clickable docs links #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aashish-Upadhyay-101 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
|
@Aashish-Upadhyay-101 wow nice work! I cannot wait to review this one 🎉 |
mfts
requested changes
Feb 12, 2024
components/view/nav.tsx
Outdated
Comment on lines
90
to
112
| <div className="absolute inset-y-0 right-0 flex items-center pr-2 sm:static sm:inset-auto sm:ml-6 sm:pr-0 space-x-4"> | ||
| {embeddedLinks && embeddedLinks.length > 0 && ( | ||
| <DropdownMenu> | ||
| <DropdownMenuTrigger> | ||
| <div className="text-sm font-semibold mr-6"> | ||
| Embedded Links | ||
| </div> | ||
| </DropdownMenuTrigger> | ||
| <DropdownMenuContent className="space-y-2 pt-2 px-4"> | ||
| {embeddedLinks.map((link, index) => ( | ||
| <Link | ||
| href={link} | ||
| target="_blank" | ||
| className="text-sm flex items-start gap-2" | ||
| key={index} | ||
| > | ||
| <span>{index + 1}.</span> | ||
| <span className="underline">{link}</span> | ||
| </Link> | ||
| ))} | ||
| </DropdownMenuContent> | ||
| </DropdownMenu> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| <div className="absolute inset-y-0 right-0 flex items-center pr-2 sm:static sm:inset-auto sm:ml-6 sm:pr-0 space-x-4"> | |
| {embeddedLinks && embeddedLinks.length > 0 && ( | |
| <DropdownMenu> | |
| <DropdownMenuTrigger> | |
| <div className="text-sm font-semibold mr-6"> | |
| Embedded Links | |
| </div> | |
| </DropdownMenuTrigger> | |
| <DropdownMenuContent className="space-y-2 pt-2 px-4"> | |
| {embeddedLinks.map((link, index) => ( | |
| <Link | |
| href={link} | |
| target="_blank" | |
| className="text-sm flex items-start gap-2" | |
| key={index} | |
| > | |
| <span>{index + 1}.</span> | |
| <span className="underline">{link}</span> | |
| </Link> | |
| ))} | |
| </DropdownMenuContent> | |
| </DropdownMenu> | |
| )} | |
| <div className="absolute inset-y-0 right-0 flex items-center pr-2 sm:static sm:inset-auto sm:ml-6 sm:pr-0 space-x-4"> | |
| {embeddedLinks && embeddedLinks.length > 0 ? ( | |
| <DropdownMenu> | |
| <DropdownMenuTrigger> | |
| <div className="text-sm font-semibold mr-6"> | |
| Embedded Links | |
| </div> | |
| </DropdownMenuTrigger> | |
| <DropdownMenuContent className="space-y-2 pt-2 px-4"> | |
| {embeddedLinks.map((link, index) => ( | |
| <Link | |
| href={link} | |
| target="_blank" | |
| className="text-sm flex items-start gap-2" | |
| key={index} | |
| > | |
| <span>{index + 1}.</span> | |
| <span className="underline">{link}</span> | |
| </Link> | |
| ))} | |
| </DropdownMenuContent> | |
| </DropdownMenu> | |
| ) : null} |
components/view/nav.tsx
Outdated
| <DropdownMenu> | ||
| <DropdownMenuTrigger> | ||
| <div className="text-sm font-semibold mr-6"> | ||
| Embedded Links |
There was a problem hiding this comment.
Suggested change
| Embedded Links | |
| Links on Page |
components/view/nav.tsx
Outdated
Comment on lines
100
to
108
| <Link | ||
| href={link} | ||
| target="_blank" | ||
| className="text-sm flex items-start gap-2" | ||
| key={index} | ||
| > | ||
| <span>{index + 1}.</span> | ||
| <span className="underline">{link}</span> | ||
| </Link> |
There was a problem hiding this comment.
You can just use a <DropdownMenuItem> from shadcn/ui and the links will be styled properly.
Please remove the numbering <span>{index + 1}.</span>, I don't think that's needed
components/view/nav.tsx
Outdated
Comment on lines
94
to
96
| <div className="text-sm font-semibold mr-6"> | ||
| Embedded Links | ||
| </div> |
There was a problem hiding this comment.
You can wrap this in a <Button> and then it will be styled well.
components/view/nav.tsx
Outdated
| DropdownMenuContent, | ||
| DropdownMenuTrigger, | ||
| } from "@/components/ui/dropdown-menu"; | ||
| import DropDown from "../web/alternatives/dropdownproto"; |
|
@mfts suggested fixes done ! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #253
@mfts the method used to implement this is very simple, will find a good work around this later ; )
for now, I think it's good.
Ready for Review