Skip to content

[lenny] fix(acp): skip the write-backpressure test where loopback cannot block #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfethe1 merged 4 commits into from
Sep 11, 2026
Merged

[lenny] fix(acp): skip the write-backpressure test where loopback cannot block #44

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41bdfb5
[lenny] fix(acp): pin socket buffers so write backpressure is OS-inde…
mfethe1 Sep 11, 2026
e482f8f
[lenny] fix(acp): pin socket buffers before connect, not after
mfethe1 Sep 11, 2026
fee1e1c
[lenny] fix(acp): gate the backpressure timing claim to where it is real
mfethe1 Sep 11, 2026
d90cf67
[lenny] fix(acp): skip the write-backpressure test where loopback can…
mfethe1 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/buzz-acp/src/relay/recovery_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,14 @@ async fn advance_clock(duration: Duration) {
tokio::time::resume();
}

// Windows loopback absorbs multi-MB writes through a fast path that ignores
// SO_SNDBUF/SO_RCVBUF, so the write this test needs to block completes instead:
// recovery then succeeds and clears the loss marker. The behaviour under test
// is unreachable there, not broken -- exercise it where backpressure is real.
#[cfg_attr(
windows,
ignore = "loopback fast path never applies write backpressure"
)]
#[tokio::test]
async fn blocked_recovery_write_is_bounded_and_retains_loss() {
let (mut client, _stalled_server) = test_ws_pair().await;
Expand Down
Loading