Skip to content

Fix MA0182 false positive for pointer type parameters #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 2 commits into from
Jan 10, 2026
Merged

Fix MA0182 false positive for pointer type parameters #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e38f036
Initial plan
Copilot Jan 10, 2026
b4673c9
Fix MA0182 to detect pointer type usages in method parameters
Copilot Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Meziantou.Analyzer/Rules/AvoidUnusedInternalTypesAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,12 @@ private void AddUsedType(ITypeSymbol typeSymbol)
AddUsedType(arrayTypeSymbol.ElementType);
}

// Handle pointer types
if (typeSymbol is IPointerTypeSymbol pointerTypeSymbol)
{
AddUsedType(pointerTypeSymbol.PointedAtType);
}

// Handle generic type arguments
if (typeSymbol is INamedTypeSymbol namedTypeSymbol)
{
Expand Down
29 changes: 29 additions & 0 deletions tests/Meziantou.Analyzer.Test/Rules/AvoidUnusedInternalTypesAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,4 +1370,33 @@ await CreateProjectBuilder()
.WithSourceCode(SourceCode)
.ValidateAsync();
}

[Fact]
public async Task InternalStructUsedAsPointerInMethodParameter_NoDiagnostic()
{
const string SourceCode = """
using System;

internal struct SECURITY_ATTRIBUTES
{
internal uint nLength;
internal IntPtr lpSecurityDescriptor;
internal bool bInheritHandle;
}

public class FileOperations
{
private static unsafe void CreateFilePrivate(
string lpFileName,
int dwDesiredAccess,
int dwShareMode,
SECURITY_ATTRIBUTES* lpSecurityAttributes)
{
}
}
""";
await CreateProjectBuilder()
.WithSourceCode(SourceCode)
.ValidateAsync();
}
}