Add MA0179: Detect inefficient attribute existence checks#939

Merged

meziantou merged 17 commits into

mainfrom

copilot/add-attribute-check-rule

Dec 18, 2025

Commits on Dec 17, 2025

Initial plan
Copilot
committed
Add UseAttributeIsDefined analyzer, fixer, and tests

Copilot
and
meziantou
committed
Update documentation for MA0179

Copilot
and
meziantou
committed
Fix code review issues: use existing IsNull method and correct pattern negation logic

Copilot
and
meziantou
committed
Address final code review feedback: simplify foreach loop and add description

Copilot
and
meziantou
committed
Add support for detecting GetCustomAttributes().Length comparisons

Copilot
and
meziantou
committed
Fix negation logic for non-left-side Length comparisons

Copilot
and
meziantou
committed
Refine Length comparison validation to only allow clear-cut patterns

Copilot
and
meziantou
committed
Add support for Count() and test for Any(attr => true)

Copilot
and
meziantou
committed
Address code review feedback: use else-if and clarify variable naming

Copilot
and
meziantou
committed
Fix logic bug in Count detection on right side

Copilot
and
meziantou
committed
Use specific IMethodSymbol for Any and Count detection

Copilot
and
meziantou
committed
Extract documentation comment IDs as constants to avoid duplication

Copilot
and
meziantou
committed
Fix test diagnostic markers to use correct span scope

Copilot
and
meziantou
committed
Fix GetCustomAttributes tests to use non-generic version for Length property

Copilot
and
meziantou
committed
Fix analyzer and fixer to properly handle extension methods

Copilot
and
meziantou
committed

Commits on Dec 18, 2025

Fix
meziantou
committed