-
-
Notifications
You must be signed in to change notification settings - Fork 61
Update MA0053 to mention both class and record types #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: meziantou <[email protected]>
|
@copilot Can you also validate that the tests validate behavior with |
Co-authored-by: meziantou <[email protected]>
I've added comprehensive tests for record types to match the coverage for classes. The tests now include:
These tests mirror the class test scenarios and confirm the analyzer properly handles records. Commit: 2a275f2 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Fix #914
The MA0053 rule already analyzes both classes and records (records are
TypeKind.Classin Roslyn), but the rule title and documentation only mentioned "class".Changes
MA0053.mdto reference both classes and records throughout configuration sections.editorconfigtemplatesThe analyzer logic remains unchanged—records were already supported.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.