- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 61
Document members of CultureInsensitiveTypeAttribute. #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document members of CultureInsensitiveTypeAttribute. #902
Conversation
| I could not compile locally. I first had to change target framework .NET 10 to .NET 9 since I don't yet have the VS2026 preview installed. Even then I got the following compile errors: .NET 9.0 build 2>Meziantou.Polyfill\Meziantou.Polyfill.PolyfillGenerator\T_System.Runtime.CompilerServices.DefaultInterpolatedStringHandler.g.cs(593,39,593,44): error CS0117: 'Math' does not contain a definition for 'Clamp'.NET Standard 2.0 build Meziantou.Analyzer\src\Meziantou.Analyzer\obj\Debug\netstandard2.0\Meziantou.Polyfill\Meziantou.Polyfill.PolyfillGenerator\T_System.Runtime.CompilerServices.DefaultInterpolatedStringHandler.g.cs(593,39,593,44): error CS0117: 'Math' does not contain a definition for 'Clamp'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\UseAnOverloadThatHasTimeProviderAnalyzer.cs(141,43,141,46): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\UseAnOverloadThatHasTimeProviderAnalyzer.cs(264,40,264,43): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\UseAnOverloadThatHasTimeProviderAnalyzer.cs(266,42,266,45): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\UseAnOverloadThatHasCancellationTokenAnalyzer.cs(239,56,239,59): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\UseAnOverloadThatHasCancellationTokenAnalyzer.cs(373,40,373,43): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\UseAnOverloadThatHasCancellationTokenAnalyzer.cs(375,42,375,45): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\FileNameMustMatchTypeNameAnalyzer.cs(113,69,113,72): error CS1503: Argument 1: cannot convert from 'char' to 'string'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\MethodOverridesShouldNotChangeParameterDefaultsAnalyzer.cs(100,23,100,29): error CS0117: 'string' does not contain a definition for 'Create'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\OptimizeLinqUsageAnalyzer.cs(564,50,564,56): error CS0117: 'string' does not contain a definition for 'Create'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\OptimizeLinqUsageAnalyzer.cs(589,50,589,56): error CS0117: 'string' does not contain a definition for 'Create'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\OptimizeLinqUsageAnalyzer.cs(612,46,612,52): error CS0117: 'string' does not contain a definition for 'Create'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\OptimizeLinqUsageAnalyzer.cs(635,46,635,52): error CS0117: 'string' does not contain a definition for 'Create'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\OptimizeLinqUsageAnalyzer.cs(657,46,657,52): error CS0117: 'string' does not contain a definition for 'Create'
Meziantou.Analyzer\src\Meziantou.Analyzer\Rules\OptimizeLinqUsageAnalyzer.cs(679,46,679,52): error CS0117: 'string' does not contain a definition for 'Create'How come you can compile for .NET Standard 2.0 while using methods that are only available in .NET? | 
| 
 The project requires .NET SDK 10 to build. It uses meziantou/Meziantou.Polyfill, a source generator that allows using newer types/methods/properties on older TFMs. In your case there is a bug (I don't know if I will fix it), where it wants to polyfill a type that uses another polyfill that C# 14 is needed ( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive XML documentation to the CultureInsensitiveTypeAttribute class, improving code maintainability and API understanding. The documentation explains how the attribute can be used to mark types and formats as culture insensitive.
Key Changes:
- Added XML documentation to all five constructor overloads explaining their purpose and usage scenarios
- Documented all three public properties (Type, Format, IsDefaultFormatCultureInsensitive) with descriptions and value explanations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
        
          
                src/Meziantou.Analyzer.Annotations/CultureInsensitiveTypeAttribute.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/Meziantou.Analyzer.Annotations/CultureInsensitiveTypeAttribute.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/Meziantou.Analyzer.Annotations/CultureInsensitiveTypeAttribute.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/Meziantou.Analyzer.Annotations/CultureInsensitiveTypeAttribute.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …bute.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
| Thanks! | 
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 2.0.230 to 2.0.236. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 2.0.236 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.236> ## What's Changed * Document members of CultureInsensitiveTypeAttribute. by @drieseng in meziantou/Meziantou.Analyzer#902 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.235...2.0.236 ## 2.0.235 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.235> ## What's Changed * Add support for culture-insensitive default formats by @meziantou in meziantou/Meziantou.Analyzer#898 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.234...2.0.235 ## 2.0.234 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.234> **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.233...2.0.234 ## 2.0.233 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.233> **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.232...2.0.233 ## 2.0.232 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.232> **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.231...2.0.232 ## 2.0.231 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.231> ## What's Changed * Improve support for culture-sensitive ToString and support null format by @meziantou in meziantou/Meziantou.Analyzer#893 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.230...2.0.231 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@2.0.230...2.0.236). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.