Apply style suggestion

.editorconfig

@@ -1,4 +1,4 @@
-# reference:https://raw.githubusercontent.com/meziantou/Meziantou.DotNet.CodingStandard/refs/heads/main/.editorconfig
+# reference:https://raw.githubusercontent.com/meziantou/Meziantou.DotNet.CodingStandard/refs/heads/main/.editorconfig
 # Schema: http://EditorConfig.org
 # Docs: https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference
 
@@ -41,7 +41,6 @@ insert_final_newline = true
 # endreference
 
 [*.cs]
-dotnet_diagnostic.IDE0058.severity = none
 dotnet_diagnostic.IDE0303.severity = none
 dotnet_diagnostic.CA1508.severity = none
 dotnet_diagnostic.CA2000.severity = none

Directory.Build.props

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Meziantou.Polyfill" Version="1.0.49">
+    <PackageReference Include="Meziantou.Polyfill" Version="1.0.61">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>

global.json

@@ -1,11 +1,11 @@
 {
   "sdk": {
-    "version": "9.0.304",
+    "version": "10.0.100-rc.2.25502.107",
     "rollForward": "latestPatch"
   },
   "msbuild-sdks": {
-    "Meziantou.NET.Sdk": "1.0.9",
-    "Meziantou.NET.Sdk.Test": "1.0.9",
-    "Meziantou.NET.Sdk.Web": "1.0.9"
+    "Meziantou.NET.Sdk": "1.0.38",
+    "Meziantou.NET.Sdk.Test": "1.0.38",
+    "Meziantou.NET.Sdk.Web": "1.0.38"
   }
 }

src/DocumentationGenerator/DocumentationGenerator.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Meziantou.Framework.FullPath" Version="1.0.17" />
+    <PackageReference Include="Meziantou.Framework.FullPath" Version="1.1.4" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0" />
   </ItemGroup>
 

src/DocumentationGenerator/Program.cs

@@ -2,8 +2,6 @@
 #pragma warning disable CA1849
 #pragma warning disable MA0004
 #pragma warning disable MA0009
-using System.Globalization;
-using System.Text;
 using System.Text.Encodings.Web;
 using System.Text.RegularExpressions;
 using Meziantou.Framework;

src/ListDotNetTypes/ListDotNetTypes.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="NuGet.Protocol" Version="6.13.2" />
+    <PackageReference Include="NuGet.Protocol" Version="6.14.0" />
   </ItemGroup>
 
 </Project>

src/Meziantou.Analyzer.CodeFixers/Internals/FixAllContextHelper.cs

@@ -1,13 +1,10 @@
-// File initially copied from
+// File initially copied from
 //  https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/4d9b3e3bb785a55f73b3029a843f0c0b73cc9ea7/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Helpers/FixAllContextHelper.cs
 // Original copyright statement:
 //  Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 //  Licensed under the MIT License. See LICENSE in the project root for license information.
 using System.Collections.Concurrent;
 using System.Collections.Immutable;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeFixes;
 
@@ -40,9 +37,7 @@ public static async Task<ImmutableDictionary<Document, ImmutableArray<Diagnostic
                 break;
 
             case FixAllScope.Solution:
-                projectsToFix = project.Solution.Projects
-                    .Where(p => p.Language == project.Language)
-                    .ToImmutableArray();
+                projectsToFix = ImmutableArray<Project>.Empty.AddRange(project.Solution.Projects.Where(p => p.Language == project.Language));
 
                 var diagnostics = new ConcurrentDictionary<ProjectId, ImmutableArray<Diagnostic>>();
                 var tasks = new Task[projectsToFix.Length];

src/Meziantou.Analyzer.CodeFixers/Meziantou.Analyzer.CodeFixers.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Meziantou.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net9.0;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net10.0;netstandard2.0</TargetFrameworks>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <Version>1.0.1</Version>
     <BaseOutputPath>bin\$(RoslynVersion)\</BaseOutputPath>

src/Meziantou.Analyzer.CodeFixers/Rules/AbstractTypesShouldNotHaveConstructorsFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/ArgumentExceptionShouldSpecifyArgumentNameFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/AvoidComparisonWithBoolConstantFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Globalization;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/AvoidUsingRedundantElseFixAllProvider.cs

@@ -1,5 +1,4 @@
-using System.Collections.Immutable;
-using System.Threading.Tasks;
+using System.Collections.Immutable;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeFixes;
 

src/Meziantou.Analyzer.CodeFixers/Rules/AvoidUsingRedundantElseFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/ClassMustBeSealedFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/CommaFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/DoNotRemoveOriginalExceptionFromThrowStatementFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/DoNotUseBlockingCallInAsyncContextFixer.cs

@@ -1,8 +1,5 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/DoNotUseEqualityComparerDefaultOfStringFixer.cs

@@ -1,8 +1,5 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/DoNotUseEqualityOperatorsForSpanOfCharFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/DoNotUseStringGetHashCodeFixer.cs

@@ -1,8 +1,5 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/EqualityShouldBeCorrectlyImplementedFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/EventsShouldHaveProperArgumentsFixer.MA0091.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/MakeClassStaticFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/MakeInterpolatedStringFixer.cs

@@ -1,15 +1,11 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Editing;
-using Microsoft.CodeAnalysis.Formatting;
 
 namespace Meziantou.Analyzer.Rules;
 

src/Meziantou.Analyzer.CodeFixers/Rules/MakeMemberReadOnlyFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/MakeMethodStaticFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
@@ -27,7 +25,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
     {
         var root = await context.Document.GetSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false);
         var nodeToFix = root?.FindNode(context.Span, getInnermostNodeForTie: true);
-        if (nodeToFix is MethodDeclarationSyntax || nodeToFix is PropertyDeclarationSyntax)
+        if (nodeToFix is MethodDeclarationSyntax or PropertyDeclarationSyntax)
         {
             var title = "Add static modifier";
             var codeAction = CodeAction.Create(

src/Meziantou.Analyzer.CodeFixers/Rules/MarkAttributesWithAttributeUsageAttributeFixer.cs

@@ -1,8 +1,5 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/MethodOverridesShouldNotChangeParameterDefaultsFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/NamedParameterFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/NotPatternShouldBeParenthesizedCodeFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/OptimizeGuidCreationFixer.cs

@@ -1,9 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Net.NetworkInformation;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/OptimizeLinqUsageFixer.cs

@@ -1,10 +1,5 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Globalization;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/OptimizeStartsWithFixer.cs

@@ -1,8 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;

src/Meziantou.Analyzer.CodeFixers/Rules/OptimizeStringBuilderUsageFixer.cs

@@ -1,11 +1,5 @@
-using System;
 using System.Collections.Immutable;
 using System.Composition;
-using System.Globalization;
-using System.Linq;
-using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
 using Meziantou.Analyzer.Internals;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
@@ -260,7 +254,7 @@ private static async Task<Document> ReplaceStringFormatWithAppendFormat(Document
         var stringFormatOperation = (IInvocationOperation)operation.Arguments[0].Value;
 
         var newExpression = generator.InvocationExpression(generator.MemberAccessExpression(operation.GetChildOperations().First().Syntax, "AppendFormat"),
-            stringFormatOperation.Arguments.Select(a => a.Syntax).ToArray());
+            [.. stringFormatOperation.Arguments.Select(a => a.Syntax)]);
 
         if (isAppendLine)
         {
@@ -285,7 +279,7 @@ private static async Task<Document> ReplaceStringJoinWithAppendJoin(Document doc
         var stringFormatOperation = (IInvocationOperation)operation.Arguments[0].Value;
 
         var newExpression = generator.InvocationExpression(generator.MemberAccessExpression(operation.GetChildOperations().First().Syntax, "AppendJoin"),
-            stringFormatOperation.Arguments.Select(a => a.Syntax).ToArray());
+            [.. stringFormatOperation.Arguments.Select(a => a.Syntax)]);
 
         if (isAppendLine)
         {

src/Meziantou.Analyzer.CodeFixers/Rules/ParameterAttributeForRazorComponentFixer.AddParameterAttribute.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;

src/Meziantou.Analyzer.CodeFixers/Rules/PreserveParamsOnOverrideFixer.cs

@@ -1,7 +1,5 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Composition;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;