Repository navigation
Do not register code fixes that do not change the code (MA0146, MA0177, MA0204) - #1744
Merged
Merged
Conversation
…7, MA0204) - MA0204: remove the partial modifier by index, as the tokens of the list created by Replace are not equal to the original ones - MA0146: only register the fix when the UnsafeAccessor attribute has no Name argument - MA0177: do not report elements whose start or end tag spans multiple lines Fixes #1741, fixes #1742, fixes #1743
This was referenced Oct 26, 2026
vdolek
pushed a commit
to EvilBrainsTechnology/EvilCase
that referenced
this pull request
Oct 26, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.315 to 3.0.317. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.317 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.317> ## What's Changed * Do not register code fixes that do not change the code (MA0146, MA0177, MA0204) by @meziantou in meziantou/Meziantou.Analyzer#1744 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.316...3.0.317 ## 3.0.316 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.316> ## What's Changed * chore(deps): update dependency meziantou.framework.roslyn to 1.2.2 by @renovate[bot] in meziantou/Meziantou.Analyzer#1740 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.315...3.0.316 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.315...3.0.317). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Oct 26, 2026
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Oct 26, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.312 to 3.0.317. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.317 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.317> ## What's Changed * Do not register code fixes that do not change the code (MA0146, MA0177, MA0204) by @meziantou in meziantou/Meziantou.Analyzer#1744 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.316...3.0.317 ## 3.0.316 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.316> ## What's Changed * chore(deps): update dependency meziantou.framework.roslyn to 1.2.2 by @renovate[bot] in meziantou/Meziantou.Analyzer#1740 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.315...3.0.316 ## 3.0.315 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.315> ## What's Changed * Use two generations in BoundedCache instead of sorting the entries by last usage by @meziantou in meziantou/Meziantou.Analyzer#1739 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.314...3.0.315 ## 3.0.314 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.314> ## What's Changed * MA0011: find the overload before computing the culture sensitivity by @meziantou in meziantou/Meziantou.Analyzer#1738 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.313...3.0.314 ## 3.0.313 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.313> ## What's Changed * Fix the CA5394 build error in BoundedCacheTests by @meziantou in meziantou/Meziantou.Analyzer#1735 * MA0243: Use an escape sequence for invisible characters by @meziantou in meziantou/Meziantou.Analyzer#1737 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.312...3.0.313 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.312...3.0.317). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Oct 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the open fuzzing issues, where a code fix was registered but applying it left the code unchanged.
partialwas not the last modifier (partial public class), the fixer calledRemove(partialKeyword)on the list returned byReplace, whose tokens are not equal to the original ones, so nothing was removed. It now removes the modifier by index.Name =without a value is reported by the analyzer (no constant name), but the fixer found aNameargument and returned the document unchanged. The fixer now validates that the attribute exists and has noNameargument before registering the fix.CreateInlineElement(shared by the analyzer and the fixer) now returnsnullin this case, so the element is no longer reported. Documented indocs/Rules/MA0177.md.Each fix has a regression test that fails without the fix. The tests of the three rules pass on all Roslyn versions (4.8, 4.14, 5.0, 5.6, 5.9), and the fuzz inputs no longer reproduce.
Fixes #1741
Fixes #1742
Fixes #1743