Skip to content

Do not register code fixes that do not change the code (MA0146, MA0177, MA0204) - #1744

Merged
meziantou merged 1 commit into
mainfrom
feature/fuzzing-issues-257f77
Oct 25, 2026
Merged

meziantou merged 1 commit into
mainfrom
feature/fuzzing-issues-257f77

Conversation

@meziantou

Copy link
Copy Markdown
Owner

Fixes the open fuzzing issues, where a code fix was registered but applying it left the code unchanged.

Each fix has a regression test that fails without the fix. The tests of the three rules pass on all Roslyn versions (4.8, 4.14, 5.0, 5.6, 5.9), and the fuzz inputs no longer reproduce.

Fixes #1741
Fixes #1742
Fixes #1743

…7, MA0204)

- MA0204: remove the partial modifier by index, as the tokens of the list created by Replace are not equal to the original ones
- MA0146: only register the fix when the UnsafeAccessor attribute has no Name argument
- MA0177: do not report elements whose start or end tag spans multiple lines

Fixes #1741, fixes #1742, fixes #1743
@meziantou
meziantou enabled auto-merge (squash) October 25, 2026 13:49
@meziantou
meziantou merged commit 0d0970f into main Oct 25, 2026
14 checks passed
@meziantou
meziantou deleted the feature/fuzzing-issues-257f77 branch October 25, 2026 13:50
This was referenced Oct 25, 2026
vdolek pushed a commit to EvilBrainsTechnology/EvilCase that referenced this pull request Oct 26, 2026
Updated
[Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer)
from 3.0.315 to 3.0.317.

<details>
<summary>Release notes</summary>

_Sourced from [Meziantou.Analyzer's
releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._

## 3.0.317

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.317>

## What's Changed
* Do not register code fixes that do not change the code (MA0146,
MA0177, MA0204) by @​meziantou in
meziantou/Meziantou.Analyzer#1744


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.316...3.0.317

## 3.0.316

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.316>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.2.2 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1740


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.315...3.0.316

Commits viewable in [compare
view](meziantou/Meziantou.Analyzer@3.0.315...3.0.317).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Meziantou.Analyzer&package-manager=nuget&previous-version=3.0.315&new-version=3.0.317)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
IhateTrains pushed a commit to ParadoxGameConverters/ImperatorToCK3 that referenced this pull request Oct 26, 2026
Updated
[Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer)
from 3.0.312 to 3.0.317.

<details>
<summary>Release notes</summary>

_Sourced from [Meziantou.Analyzer's
releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._

## 3.0.317

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.317>

## What's Changed
* Do not register code fixes that do not change the code (MA0146,
MA0177, MA0204) by @​meziantou in
meziantou/Meziantou.Analyzer#1744


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.316...3.0.317

## 3.0.316

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.316>

## What's Changed
* chore(deps): update dependency meziantou.framework.roslyn to 1.2.2 by
@​renovate[bot] in
meziantou/Meziantou.Analyzer#1740


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.315...3.0.316

## 3.0.315

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.315>

## What's Changed
* Use two generations in BoundedCache instead of sorting the entries by
last usage by @​meziantou in
meziantou/Meziantou.Analyzer#1739


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.314...3.0.315

## 3.0.314

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.314>

## What's Changed
* MA0011: find the overload before computing the culture sensitivity by
@​meziantou in meziantou/Meziantou.Analyzer#1738


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.313...3.0.314

## 3.0.313

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.313>

## What's Changed
* Fix the CA5394 build error in BoundedCacheTests by @​meziantou in
meziantou/Meziantou.Analyzer#1735
* MA0243: Use an escape sequence for invisible characters by @​meziantou
in meziantou/Meziantou.Analyzer#1737


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.312...3.0.313

Commits viewable in [compare
view](meziantou/Meziantou.Analyzer@3.0.312...3.0.317).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Meziantou.Analyzer&package-manager=nuget&previous-version=3.0.312&new-version=3.0.317)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant