Skip to content

MA0011: do not bind the invocations of attribute arguments speculatively #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 1 commit into from
Oct 18, 2026
+24 −0
Merged

MA0011: do not bind the invocations of attribute arguments speculatively #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Meziantou.Analyzer.CodeFixers/Internals/ArgumentListHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,17 @@ public static InvocationExpressionSyntax WithArguments(InvocationExpressionSynta
private sealed class BindingContext(SemanticModel semanticModel, InvocationExpressionSyntax invocationExpression, string? namespaceToImport, CancellationToken cancellationToken)
{
private readonly bool _isInConditionalAccess = IsInConditionalAccess(invocationExpression.Expression);

// An attribute argument must be a constant (CS0182), so an invocation cannot be one, and the speculative binding can throw there
private readonly bool _isInAttributeArgument = invocationExpression.FirstAncestorOrSelf<AttributeArgumentSyntax>() is not null;

private (SemanticModel SemanticModel, int Position)? _bindingLocation;

public IMethodSymbol? GetTargetMethod(InvocationExpressionSyntax newInvocation)
{
if (_isInAttributeArgument)
return null;

if (_isInConditionalAccess)
{
var (newSemanticModel, newNode) = ReplaceInvocation(newInvocation);
Expand Down
17 changes: 17 additions & 0 deletions tests/Meziantou.Analyzer.Test/Rules/UseIFormatProviderAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,4 +1283,21 @@ public static class SampleExtensions

return test.RunAsync();
}

[Fact]
[Trait("Issue", "https://github.com/meziantou/Meziantou.Analyzer/issues/1686")]
public Task InvalidCode_InvocationInAttributeArgument_NoCodeFix()
{
const string Source = """
[assembly:({|MA0011:string.Format(""new object[]{-1a is g System
|}using>
""";
var test = CreateTest();
// The code does not compile, so the compiler diagnostics cannot be verified
test.CompilerDiagnostics = CompilerDiagnostics.None;
test.TestCode = Source;
test.FixedCode = Source;

return test.RunAsync();
}
}
Loading