[meziantou]

Fixes #1644
Fixes #1650

Analyzer crash on invalid code (#1644)

MakeMethodStaticAnalyzer called SemanticModel.GetOperation on the method bodies. On some invalid code (A(B$@ = 0);), Roslyn throws while building the operation tree (Unexpected value 'UnconvertedInterpolatedString'), and the exception was attributed to the analyzer. The analyzer now uses RegisterOperationBlockAction, so Roslyn creates the operations and the rule only receives them. The properties are analyzed per accessor and aggregated at the end of the compilation, as before.

The code fix broke the code

Making a member static breaks the code that accesses it through an instance. The fuzzer found these cases, so the rule no longer reports them:

• a member accessed through an instance other than this/base: ((Test)null)?.A() ([Fuzzing] MA0038 (MakeMethodStaticFixer) code fix introduces CS0176 #1650, CS0176), instance.A(), an object initializer (CS1914), a property pattern
• a member that uses a parameter of the primary constructor (CS9105, CS0165)
• a member that the compiler binds by name on an instance, such as DisposeAsync for await using (CS8417) or Add for a collection expression (CS1921)

The code fix also:

• replaces this.A() and base.A() with A() in all the documents of the solution
• removes the readonly modifier of a struct member (CS8657)
• keeps the indentation when the member has no modifier (Roslyn 4.8 added a blank line)

Tests

Regression tests for each case in MakeMethodStaticAnalyzerTests. The fuzz inputs no longer reproduce with dotnet run --project tests/Meziantou.Analyzer.Fuzz -c Release -- repro.