Fix MA0046 reporting override events - #1599
Merged
Merged
Conversation
meziantou
marked this pull request as ready for review
September 23, 2026 03:59
This was referenced Sep 23, 2026
Bump Meziantou.Analyzer from 3.0.139 to 3.0.283
Analogy-LogViewer/Analogy.LogViewer.NLog.Targets#582
Closed
Closed
Bump Meziantou.Analyzer from 3.0.139 to 3.0.283
Analogy-LogViewer/Analogy.AspNetCore.LogProvider#563
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MA0046 (Use EventHandler to declare events) skipped the interface implementations, but not the overrides, so the same event was reported on the base declaration and on each override, whose type cannot be changed:
Expected: 1 diagnostic (on
Base.E). Actual: 2 diagnostics.Fix
The analyzer skips
overrideevents, like the interface implementations.docs/Rules/MA0046.mdmentions both.Tests
Added
OverridetoUseEventHandlerOfTAnalyzerTests(failed before the fix). The test class passes on roslyn5.9 (16/16) and roslyn4.8 (16/16).