Do not report MA0028 for concatenation of constant strings and chars - #1529
Merged
Merged
Conversation
This was referenced Sep 18, 2026
Closed
Closed
Closed
Closed
This was referenced Oct 1, 2026
Merged
Open
Open
Open
Bump Meziantou.Analyzer from 3.0.139 to 3.0.291
Analogy-LogViewer/Analogy.LogViewer.NLog.Targets#586
Open
Bump Meziantou.Analyzer from 3.0.139 to 3.0.291
Analogy-LogViewer/Analogy.AspNetCore.LogProvider#565
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1528
MA0028 reported
sb.Append(" " + Const + " ")whereConstis aconst char, although the compiler merges this concatenation into a single string. Thecharoperand is an implicit conversion rather than a constant string, and the left side is itself a nested concatenation, so the rule did not recognize it as constant.Changes:
IsConstStringnow also accepts an implicit conversion of a constantchar, and a string+whose operands are all constant (recursively)."a" + 'b' + 10) are still reported.docs/Rules/MA0028.md.MA0028 tests pass on Roslyn 5.9 and 4.8.