Skip to content

Fix MA0018 reporting one diagnostic per event accessor #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 1 commit into from
Sep 12, 2026
Merged

Fix MA0018 reporting one diagnostic per event accessor #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Meziantou.Analyzer/Rules/DoNotDeclareStaticMembersOnGenericTypes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ private static void Analyze(SymbolAnalysisContext context)
if (member.IsAbstract || member.IsVirtual)
continue;

// skip properties
if (member is IMethodSymbol method && (method.MethodKind == MethodKind.PropertyGet || method.MethodKind == MethodKind.PropertySet))
// The accessors are reported through the property or event they belong to
if (member is IMethodSymbol { MethodKind: MethodKind.PropertyGet or MethodKind.PropertySet or MethodKind.EventAdd or MethodKind.EventRemove })
continue;

// skip operators
Expand Down
32 changes: 32 additions & 0 deletions tests/Meziantou.Analyzer.Test/Rules/DoNotDeclareStaticMembersOnGenericTypesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,38 @@ public class Test<T>
return test.RunAsync();
}

[Fact]
public Task StaticMembers_Event()
{
var test = CreateTest();
test.TestCode = """
public class Test<T>
{
public static event System.EventHandler {|MA0018:MyEvent|};
}
""";

return test.RunAsync();
}

[Fact]
public Task StaticMembers_EventWithExplicitAccessors()
{
var test = CreateTest();
test.TestCode = """
public class Test<T>
{
public static event System.EventHandler {|MA0018:MyEvent|}
{
add => throw null;
remove => throw null;
}
}
""";

return test.RunAsync();
}

[Fact]
public Task StaticMembers_Operator()
{
Expand Down