Do not report MA0005 for arrays of pointers - #1460
Merged
Merged
Conversation
Pointer and function pointer types cannot be used as generic type arguments, so replacing `new int*[0]` with `Array.Empty<int*>()` produced code that fails with CS0306.
This was referenced Sep 12, 2026
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MA0005 reported zero-length arrays of pointers, and its code fix produced code that does not compile:
became
Pointer and function pointer types cannot be used as generic type arguments.
Change
UseArrayEmptyAnalyzerno longer reports when the array's element type is a pointer or a function pointer. The code fix only runs on this diagnostic, so it is no longer offered either.new int*[0][]) are still reported, sinceArray.Empty<int*[]>()is valid.docs/Rules/MA0005.mddocuments the exclusion.Tests
EmptyPointerArray_ShouldNotReportError:new int*[0],new int*[] { },new delegate*<void>[0]EmptyArrayOfPointerArrays_ShouldReportError:new int*[0][]is still fixed toSystem.Array.Empty<int*[]>()All 12
UseArrayEmptyAnalyzerTestspass on Roslyn 5.9 and 4.8. With the analyzer change reverted, the three pointer cases fail. I ran only these tests locally; CI runs the other Roslyn versions.