Preserve interpolation alignment in MA0052 code fix - #1454
Merged
Merged
Conversation
The fixer replaced the interpolation with a new one containing only the
nameof expression, which dropped the alignment clause and changed the
padded output (e.g. $"[{Color.Red,10}]" became $"[{nameof(Color.Red)}]").
The fixer now only replaces the expression and removes the format clause,
which is safe as the reported formats (G, F, empty) already produce the
name of the value.
…olation-alignment-d5ac30 # Conflicts: # src/Meziantou.Analyzer.CodeFixers/Rules/ReplaceEnumToStringWithNameofFixer.cs
meziantou
enabled auto-merge (squash)
September 11, 2026 19:24
This was referenced Sep 11, 2026
Closed
This was referenced Sep 17, 2026
Merged
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MA0052 code fix (replace constant
Enum.ToStringwithnameof) dropped the alignment clause of interpolations, which changed the output of the code:Changes
ReplaceEnumToStringWithNameofFixernow updates the existingInterpolationSyntaxinstead of creating a new one: the expression is replaced bynameof(...)and the alignment clause is kept.G,g,F,f, or none).InterpolatedString_Alignmenttest covering positive and negative widths, with and without a format clause, plus a non-reported:Dcase.Validation
ReplaceEnumToStringWithNameofAnalyzerTestspass on roslyn4.8, 4.14, 5.0, 5.6 and 5.9 (15/15 each).dotnet run --project src/DocumentationGeneratorproduces no changes.