Skip to content

Remove dead VSIX release scripts - #1404

Merged
meziantou merged 1 commit into
mainfrom
feature/remove-dead-release-scripts-518c66
Sep 6, 2026
Merged

meziantou merged 1 commit into
mainfrom
feature/remove-dead-release-scripts-518c66

Conversation

@meziantou

Copy link
Copy Markdown
Owner

What

Deletes build/publish-vsix.ps1, build/update-version.ps1 and build/extension-manifest.json. Those were the only files in build/, so the directory goes away with them.

Why

Every path the two scripts write to is gone:

  • src/Meziantou.Analyzer.Vsix/ was removed in adf9e87 ("Use GitHub Actions and Remove VSIX package"), which takes out both the .vsix payload publish-vsix.ps1 publishes and the source.extension.vsixmanifest that update-version.ps1 rewrites.
  • src/Meziantou.Analyzer/Meziantou.Analyzer.csproj, the other file update-version.ps1 rewrites, no longer exists either — the analyzer is now Meziantou.Analyzer.roslyn<version>.csproj.

update-version.ps1 is also fully superseded: the CI workflow computes the version inline and passes /p:Version= to build and pack.

extension-manifest.json describes a marketplace extension that is no longer produced.

Beyond the hygiene, these are release scripts — they documented a second, abandoned distribution channel and a PAT-based publish flow, the kind of stale artifact that gets resurrected and run against a stale identity.

Notes for the reviewer

  • Nothing invokes these scripts: no reference anywhere outside build/ itself, and no .ps1 invocation in .github/.
  • The one nearby hit is <None Include="build/**" .../> in src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj. It is project-relative — dotnet msbuild -getItem:None resolves it solely to src/Meziantou.Analyzer.Pack/build/Meziantou.Analyzer.props, never the repo-root folder. Packing is unaffected.
  • The .gitignore comment about build/ refers to **/packages/build/, not this folder.
  • No build or test run: these files are not inputs to any project, so no compiled code or test is affected.
  • Not something this PR can do — if a Visual Studio Marketplace PAT still exists for the old publish flow, it is worth revoking. No CI secret references one (the only secrets. use in the repo is GITHUB_TOKEN in close-issues.yml), so any surviving token would live in the Azure DevOps account rather than in this repo.

build/publish-vsix.ps1, build/update-version.ps1 and
build/extension-manifest.json all target paths that no longer exist:
src/Meziantou.Analyzer.Vsix was removed in adf9e87 along with the VSIX
package, and src/Meziantou.Analyzer/Meziantou.Analyzer.csproj is now
Meziantou.Analyzer.roslyn<version>.csproj.

Nothing invokes them. The version is computed inline by the CI workflow
and passed as /p:Version= to build and pack, so update-version.ps1 is
superseded. The build/** include of Meziantou.Analyzer.Pack.csproj is
project relative and resolves only to the build folder of that project,
not to this one.

These being release scripts, they also documented an abandoned
distribution channel and a PAT based publish flow.
@meziantou
meziantou enabled auto-merge (squash) September 6, 2026 04:20
@meziantou
meziantou merged commit 4b137c4 into main Sep 6, 2026
13 checks passed
@meziantou
meziantou deleted the feature/remove-dead-release-scripts-518c66 branch September 6, 2026 04:20
This was referenced Sep 6, 2026
This was referenced Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant