Remove dead VSIX release scripts - #1404
Merged
Merged
Conversation
build/publish-vsix.ps1, build/update-version.ps1 and build/extension-manifest.json all target paths that no longer exist: src/Meziantou.Analyzer.Vsix was removed in adf9e87 along with the VSIX package, and src/Meziantou.Analyzer/Meziantou.Analyzer.csproj is now Meziantou.Analyzer.roslyn<version>.csproj. Nothing invokes them. The version is computed inline by the CI workflow and passed as /p:Version= to build and pack, so update-version.ps1 is superseded. The build/** include of Meziantou.Analyzer.Pack.csproj is project relative and resolves only to the build folder of that project, not to this one. These being release scripts, they also documented an abandoned distribution channel and a PAT based publish flow.
meziantou
enabled auto-merge (squash)
September 6, 2026 04:20
This was referenced Sep 6, 2026
Closed
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
build/publish-vsix.ps1,build/update-version.ps1andbuild/extension-manifest.json. Those were the only files inbuild/, so the directory goes away with them.Why
Every path the two scripts write to is gone:
src/Meziantou.Analyzer.Vsix/was removed in adf9e87 ("Use GitHub Actions and Remove VSIX package"), which takes out both the.vsixpayloadpublish-vsix.ps1publishes and thesource.extension.vsixmanifestthatupdate-version.ps1rewrites.src/Meziantou.Analyzer/Meziantou.Analyzer.csproj, the other fileupdate-version.ps1rewrites, no longer exists either — the analyzer is nowMeziantou.Analyzer.roslyn<version>.csproj.update-version.ps1is also fully superseded: the CI workflow computes the version inline and passes/p:Version=to build and pack.extension-manifest.jsondescribes a marketplace extension that is no longer produced.Beyond the hygiene, these are release scripts — they documented a second, abandoned distribution channel and a PAT-based publish flow, the kind of stale artifact that gets resurrected and run against a stale identity.
Notes for the reviewer
build/itself, and no.ps1invocation in.github/.<None Include="build/**" .../>insrc/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj. It is project-relative —dotnet msbuild -getItem:Noneresolves it solely tosrc/Meziantou.Analyzer.Pack/build/Meziantou.Analyzer.props, never the repo-root folder. Packing is unaffected..gitignorecomment aboutbuild/refers to**/packages/build/, not this folder.secrets.use in the repo isGITHUB_TOKENinclose-issues.yml), so any surviving token would live in the Azure DevOps account rather than in this repo.