Remove DisabledDiagnostics from the tests - #1370
Merged
Merged
Conversation
… stop disabling MA0043 The MA0043 tests lived in their own class and the other class disabled MA0043, even though no test snippet reported it. Both rules of the analyzer are now verified by a single class.
MA0105 and MA0106 had one test class each, disabling the other rule. The snippets that report both rules now flag MA0106 explicitly.
The MA0133 class disabled MA0132 and held a single test that the MA0132 class already covered verbatim.
The async and non-async context classes disabled each other's rule. Only one snippet actually reported the other rule, and it now flags MA0045.
MA0065 and MA0066 had one test class each, disabling the other rule, even though no snippet reported both.
The MA0077 class disabled MA0095 because fixing MA0077 adds IEquatable<T>, which makes MA0095 report on the result. Those tests now assert a single fix application and flag MA0095 in the fixed code.
MA0038 and MA0041 had one test class each, disabling the other rule.
…ix tests MA0156 and MA0157 contradict each other, so the fix of one reveals the other. The two code fix tests now assert a single fix application and flag the contradicting rule in the fixed code.
Nine classes covered one rule each and disabled all the others. The order related tests used identity selectors, which made MA0159 report on them; they now use a real selector so each test stays focused on the rule it covers.
MA0087 and MA0088 had one test class each, disabling the other rule. Fixing MA0088 reveals MA0087, so that test now asserts a single fix application and flags MA0087 in the fixed code.
Every test disabled the two rules it did not cover, even though no snippet reported more than one of MA0161, MA0162 and MA0163.
The snippets that report MA0154, MA0218 or MA0219 in addition to the rule under test now flag them.
MA0001 and MA0074 had one test class each, disabling the other rule, with five tests duplicated between them. The char overload tests now flag MA0001 and assert its fix.
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every
DisabledDiagnosticsusage from the tests (75 calls across 26 files, now 0). Most of them were leftovers from the migration to the Roslyn SDK harness: the original tests filtered the diagnostics to a single rule, so each rule of a multi-rule analyzer got its own test class that disabled all the others.There is one commit per analyzer.
What changed
Merged the per-rule test classes (24 classes → 10). Each merged class now runs every rule its analyzer reports, so a snippet that triggers two rules has to say so:
OptimizeLinqUsageAnalyzerOptimizeLinqUsageAnalyzerTestsEqualityShouldBeCorrectlyImplementedAnalyzerEqualityShouldBeCorrectlyImplementedAnalyzerTestsDoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContext/_NonAsyncContextDoNotUseBlockingCallInAsyncContextAnalyzerTestsMakeMethodStaticAnalyzer_Methods/_PropertiesMakeMethodStaticAnalyzerTestsAvoidClosureWhenUsingConcurrentDictionaryAnalyzerConcurrentDictionaryMustPreventClosureWhenAccessingTheKeyAnalyzerTestsOptionalParametersAttributeAnalyzerOptionalParametersAttributeAnalyzerTestsUseStringComparisonAnalyzerUseStringComparisonAnalyzerTestsDoNotUseDefaultEqualsOnValueTypeAnalyzerDoNotUseDefaultEqualsOnValueTypeAnalyzerTestsDoNotImplicitlyConvertDateTimeToDateTimeOffsetAnalyzerDoNotCompareDateTimeWithDateTimeOffsetAnalyzerTestsArgumentExceptionShouldSpecifyArgumentNameAnalyzerArgumentExceptionShouldSpecifyArgumentNameAnalyzerTestsColliding method names got a disambiguating prefix or suffix. Six tests that were byte-identical duplicates across a merged pair were dropped (one in the DateTimeOffset pair, five in the
UseStringComparisonpair) — no coverage is lost, the surviving copy asserts exactly the same thing.Flagged the diagnostics the fix reveals, using the pattern already in the repo (
FixedState.MarkupHandling = MarkupMode.Allow+CodeFixTestBehaviors.FixOne), so the test asserts a single fix application and the new diagnostic is visible in the expected code:IEquatable<T>, which makes MA0095 report on the result (8 tests)Flagged the other rules in the test code where a snippet reported more than the rule under test:
UseLangwordInXmlComment(MA0154 / MA0218 / MA0219),UseStringComparison(the char overload tests now flag MA0001 and assert its fix), oneDoNotUseBlockingCallInAsyncContextsnippet (MA0045), and threeAvoidClosureWhenUsingConcurrentDictionarysnippets (MA0106).Removed the disabling that was pure noise:
ProcessStartAnalyzerdisabled the two rules each test did not cover, andArgumentExceptionShouldSpecifyArgumentNamedisabled MA0043, even though no snippet reported them.Note for the reviewer
Three
OptimizeLinqUsageorder tests reported MA0159 only because their samples used an identity selector (OrderBy(x => x)). Flagging MA0159 there was not an option: withFixOne, the harness applied the MA0159 fix instead of the one under test, rewriting the sample toOrder()and destroying what the test verified. Those samples now use a real selector (x => -x,x => x.Length) so the tests stay focused on MA0030 and MA0063.Validation
dotnet buildon the solution: 0 warnings, 0 errorsdotnet run --project src/DocumentationGeneratorproduced no markdown changes