Add a Roslyn 5.9 target - #1288
Merged
Merged
Conversation
Roslyn 5.9.0 is the latest release, so add it as a build/test target and make it the version the `default` configuration resolves to. - `Directory.Build.targets`: new `roslyn5.9` block defining `ROSLYN5_9` and `ROSLYN_5_9_OR_GREATER`; `Otherwise` now tracks 5.9.0. C# 15 support is attributed to 5.9 rather than 5.6. - `Meziantou.Analyzer.Pack.csproj`: pack the assemblies under `analyzers/dotnet/roslyn5.9/cs/`. - `ci.yml`: build the 5.9 assemblies for the package and add `roslyn5.9` to the test matrix. - `ProjectBuilder`: use `Microsoft.CodeAnalysis.CSharp.CodeStyle` 5.9.0 when building against Roslyn 5.9 or later. - `LanguageVersionExtensions.IsCSharp15OrAbove`: drop the conditional compilation, the comparison works on every supported Roslyn version. - `AGENTS.md`: refresh the supported-version list, which still mentioned the removed 4.2/4.4/4.6 targets.
This was referenced Aug 17, 2026
Open
Bump Meziantou.Analyzer from 3.0.103 to 3.0.163
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#90
Open
Open
Open
Bump Meziantou.Analyzer from 3.0.139 to 3.0.163
Analogy-LogViewer/Analogy.LogViewer.NLog.Targets#549
Open
This was referenced Aug 18, 2026
Open
Bump Meziantou.Analyzer from 3.0.139 to 3.0.163
Analogy-LogViewer/Analogy.AspNetCore.LogProvider#535
Open
Open
Open
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
roslyn5.9as a supported build/test target and makes it the version thedefaultconfiguration resolves to, following the existing convention whereOtherwisemirrors the newest target.Directory.Build.targets— newroslyn5.9block referencing Microsoft.CodeAnalysis 5.9.0, definingROSLYN5_9andROSLYN_5_9_OR_GREATER.Otherwisenow tracks 5.9.0. C# 15 support (CSHARP15_OR_GREATER) is attributed to 5.9 rather than 5.6.Meziantou.Analyzer.Pack.csproj— packs the analyzer and code fixer underanalyzers/dotnet/roslyn5.9/cs/.ci.yml— builds the 5.9 assemblies increate_nugetand addsroslyn5.9to thebuild_and_testmatrix.ProjectBuilder— usesMicrosoft.CodeAnalysis.CSharp.CodeStyle5.9.0 when building against Roslyn 5.9 or later.LanguageVersionExtensions.IsCSharp15OrAbove— drops the#if CSHARP15_OR_GREATERguard; the numeric comparison compiles and behaves correctly on every supported Roslyn version.AGENTS.md— refreshes the supported-version list, which was stale (it still listed the removed 4.2/4.4/4.6 targets and claimeddefaultwas 5.0.0).Notes for reviewers
LanguageVersionenum in the shipped 5.9.0 package — so theCSHARP*constants stop at 15.defaultnow resolves to 5.9.0, thedefaultCI leg duplicates theroslyn5.9leg. That matches the prior state, wheredefaultduplicatedroslyn5.6.Testing
Full suite run locally against every target, all passing:
roslyn4.8roslyn4.14roslyn5.0roslyn5.6roslyn5.9dotnet run --project src/DocumentationGeneratorreports no markdown changes.