Fix MA0202 false positive for comment-only branches - #1257
Merged
meziantou merged 3 commits intoAug 1, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
meziantou
enabled auto-merge (squash)
August 1, 2026 00:22
meziantou
deleted the
meziantou-fix-ma0202-false-positive-comment-only-b
branch
August 1, 2026 00:22
This was referenced Aug 1, 2026
This was referenced Aug 6, 2026
Closed
Open
Open
Open
Open
Bump Meziantou.Analyzer from 3.0.103 to 3.0.140
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#81
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0202 could report a false positive when conditional compilation branches only contained comments (including XML documentation comments). In that case, tokenization produced an empty signature for each branch, so different comment-only branches were treated as identical.
This change updates branch signature computation to fall back to trimmed raw text when a branch has no tokens, while keeping the existing token-based comparison for branches that contain code. It also adds regression tests for both different and identical XML-comment-only branches, and updates MA0202 documentation to reflect the behavior.
Fixes: #1255
Fixes: #1256