Fix MA0194 invalid pattern merges#1212
Merged
Merged
Conversation
meziantou
changed the title
meziantou
force-pushed
the
codex/fix-ma0194-invalid-pattern-merge
branch
from
July 3, 2026 15:46
2c46148 to
286aa44
Compare
meziantou
marked this pull request as ready for review
July 3, 2026 16:02
This was referenced Jul 3, 2026
Closed
Bump Meziantou.Analyzer from 3.0.103 to 3.0.119
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#59
Closed
Merged
Merged
This was referenced Jul 13, 2026
Open
Open
Open
Bump Meziantou.Analyzer from 3.0.103 to 3.0.123
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#66
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MA0194 so it does not report or offer a merge when the resulting pattern would be invalid because a variable designation would be placed inside a not or or pattern.
The analyzer now carries pattern syntax with merge candidates and validates the merged pattern shape before reporting. The fixer uses the same guard before creating a merged pattern.
Validation