Skip to content

Perf: Cache symbols per compilation #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 3 commits into from
May 28, 2026
+730 −697
Merged

Perf: Cache symbols per compilation #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6269ac3
Cache symbols
meziantou May 28, 2026
7c7724d
wip
meziantou May 28, 2026
5840b05
wip
meziantou May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
211 changes: 107 additions & 104 deletions src/Meziantou.Analyzer/Internals/TimeSpanOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,146 +2,149 @@
using Microsoft.CodeAnalysis.Operations;

namespace Meziantou.Analyzer.Internals;
internal static class TimeSpanOperation

internal sealed class TimeSpanOperation(Compilation compilation)
{
internal static long? GetMilliseconds(IOperation op)
private readonly ISymbol? _timeSpanSymbol = compilation.GetBestTypeByMetadataName("System.TimeSpan");
private readonly ISymbol? _regexSymbol = compilation.GetBestTypeByMetadataName("System.Text.RegularExpressions.Regex");
private readonly ISymbol? _timeoutSymbol = compilation.GetBestTypeByMetadataName("System.Threading.Timeout");

public long? GetMilliseconds(IOperation op)
{
if (op.SemanticModel is null)
return null;

if (!op.Type.IsEqualTo(op.SemanticModel.Compilation.GetBestTypeByMetadataName("System.TimeSpan")))
if (!op.Type.IsEqualTo(_timeSpanSymbol))
return null;

return GetMilliseconds(op, 1d);
}

static long? GetMilliseconds(IOperation op, double factor)
private long? GetMilliseconds(IOperation op, double factor)
{
const double TicksToMilliseconds = 1d / TimeSpan.TicksPerMillisecond;
const double SecondsToMilliseconds = 1000;
const double MinutesToMilliseconds = 60 * 1000;
const double HoursToMilliseconds = 60 * 60 * 1000;
const double DaysToMilliseconds = 24 * 60 * 60 * 1000;

op = op.UnwrapImplicitConversionOperations();
if (op.ConstantValue.HasValue)
{
var compilation = op.SemanticModel!.Compilation;
if (op.ConstantValue.HasValue && op.ConstantValue.Value is long int64Value)
return (long)(int64Value * factor);

const double TicksToMilliseconds = 1d / TimeSpan.TicksPerMillisecond;
const double SecondsToMilliseconds = 1000;
const double MinutesToMilliseconds = 60 * 1000;
const double HoursToMilliseconds = 60 * 60 * 1000;
const double DaysToMilliseconds = 24 * 60 * 60 * 1000;
if (op.ConstantValue.HasValue && op.ConstantValue.Value is int int32Value)
return (long)(int32Value * factor);

op = op.UnwrapImplicitConversionOperations();
if (op.ConstantValue.HasValue)
{
if (op.ConstantValue.HasValue && op.ConstantValue.Value is long int64Value)
return (long)(int64Value * factor);
if (op.ConstantValue.HasValue && op.ConstantValue.Value is double doubleValue)
return (long)(doubleValue * factor);
}

if (op.ConstantValue.HasValue && op.ConstantValue.Value is int int32Value)
return (long)(int32Value * factor);
if (op is IDefaultValueOperation)
return 0L;

if (op.ConstantValue.HasValue && op.ConstantValue.Value is double doubleValue)
return (long)(doubleValue * factor);
if (op is IInvocationOperation invocationOperation)
{
var method = invocationOperation.TargetMethod;
if (method.IsStatic && method.ContainingType.IsEqualTo(_timeSpanSymbol))
{
return method.Name switch
{
"FromTicks" => GetMilliseconds(invocationOperation.Arguments[0].Value, TicksToMilliseconds),
"FromMilliseconds" => GetMilliseconds(invocationOperation.Arguments[0].Value, 1),
"FromSeconds" => GetMilliseconds(invocationOperation.Arguments[0].Value, SecondsToMilliseconds),
"FromMinutes" => GetMilliseconds(invocationOperation.Arguments[0].Value, MinutesToMilliseconds),
"FromHours" => GetMilliseconds(invocationOperation.Arguments[0].Value, HoursToMilliseconds),
"FromDays" => GetMilliseconds(invocationOperation.Arguments[0].Value, DaysToMilliseconds),
_ => null,
};
}

if (op is IDefaultValueOperation)
return 0L;
return null;
}

if (op is IInvocationOperation invocationOperation)
if (op is IFieldReferenceOperation fieldReferenceOperation)
{
var member = fieldReferenceOperation.Member;
if (member.IsStatic && member.ContainingType.IsEqualTo(_timeSpanSymbol))
{
var method = invocationOperation.TargetMethod;
if (method.IsStatic && method.ContainingType.IsEqualTo(compilation.GetBestTypeByMetadataName("System.TimeSpan")))
return member.Name switch
{
return method.Name switch
{
"FromTicks" => GetMilliseconds(invocationOperation.Arguments[0].Value, TicksToMilliseconds),
"FromMilliseconds" => GetMilliseconds(invocationOperation.Arguments[0].Value, 1),
"FromSeconds" => GetMilliseconds(invocationOperation.Arguments[0].Value, SecondsToMilliseconds),
"FromMinutes" => GetMilliseconds(invocationOperation.Arguments[0].Value, MinutesToMilliseconds),
"FromHours" => GetMilliseconds(invocationOperation.Arguments[0].Value, HoursToMilliseconds),
"FromDays" => GetMilliseconds(invocationOperation.Arguments[0].Value, DaysToMilliseconds),
_ => null,
};
}

return null;
"Zero" => 0,
"MinValue" => (long)TimeSpan.MinValue.TotalMilliseconds,
"MaxValue" => (long)TimeSpan.MaxValue.TotalMilliseconds,
_ => null,
};
}

if (op is IFieldReferenceOperation fieldReferenceOperation)
if (member.IsStatic && member.ContainingType.IsEqualTo(_regexSymbol))
{
var member = fieldReferenceOperation.Member;
if (member.IsStatic && member.ContainingType.IsEqualTo(compilation.GetBestTypeByMetadataName("System.TimeSpan")))
{
return member.Name switch
{
"Zero" => 0,
"MinValue" => (long)TimeSpan.MinValue.TotalMilliseconds,
"MaxValue" => (long)TimeSpan.MaxValue.TotalMilliseconds,
_ => null,
};
}

if (member.IsStatic && member.ContainingType.IsEqualTo(compilation.GetBestTypeByMetadataName("System.Text.RegularExpressions.Regex")))
{
return member.Name switch
{
"InfiniteMatchTimeout" => -1L,
_ => null,
};
}

if (member.IsStatic && member.ContainingType.IsEqualTo(compilation.GetBestTypeByMetadataName("System.Threading.Timeout")))
return member.Name switch
{
return member.Name switch
{
"InfiniteTimeSpan" => -1L,
"Infinite" => -1L,
_ => null,
};
}

return null;
"InfiniteMatchTimeout" => -1L,
_ => null,
};
}

if (op is IObjectCreationOperation objectCreationOperation)
if (member.IsStatic && member.ContainingType.IsEqualTo(_timeoutSymbol))
{
if (objectCreationOperation.Type.IsEqualTo(compilation.GetBestTypeByMetadataName("System.TimeSpan")))
return member.Name switch
{
return objectCreationOperation.Arguments.Length switch
{
// new TimeSpan(long ticks)
1 => GetMilliseconds(objectCreationOperation.Arguments[0].Value, 1d / TimeSpan.TicksPerMillisecond),

// new TimeSpan(int hours, int minutes, int seconds)
3 => AddValues(GetMilliseconds(objectCreationOperation.Arguments[0].Value, HoursToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[1].Value, MinutesToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[2].Value, SecondsToMilliseconds)),

// new TimeSpan(int days, int hours, int minutes, int seconds)
4 => AddValues(GetMilliseconds(objectCreationOperation.Arguments[0].Value, DaysToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[1].Value, HoursToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[2].Value, MinutesToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[3].Value, SecondsToMilliseconds)),

// new TimeSpan(int days, int hours, int minutes, int seconds, int milliseconds)
5 => AddValues(GetMilliseconds(objectCreationOperation.Arguments[0].Value, DaysToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[1].Value, HoursToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[2].Value, MinutesToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[3].Value, SecondsToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[4].Value, 1)),
_ => null,
};
}
"InfiniteTimeSpan" => -1L,
"Infinite" => -1L,
_ => null,
};
}

return null;
}

static long? AddValues(params ReadOnlySpan<long?> values)
if (op is IObjectCreationOperation objectCreationOperation)
{
if (objectCreationOperation.Type.IsEqualTo(_timeSpanSymbol))
{
var result = 0L;
foreach (var value in values)
return objectCreationOperation.Arguments.Length switch
{
if (!value.HasValue)
return null;
// new TimeSpan(long ticks)
1 => GetMilliseconds(objectCreationOperation.Arguments[0].Value, 1d / TimeSpan.TicksPerMillisecond),

// new TimeSpan(int hours, int minutes, int seconds)
3 => AddValues(GetMilliseconds(objectCreationOperation.Arguments[0].Value, HoursToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[1].Value, MinutesToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[2].Value, SecondsToMilliseconds)),

// new TimeSpan(int days, int hours, int minutes, int seconds)
4 => AddValues(GetMilliseconds(objectCreationOperation.Arguments[0].Value, DaysToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[1].Value, HoursToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[2].Value, MinutesToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[3].Value, SecondsToMilliseconds)),

// new TimeSpan(int days, int hours, int minutes, int seconds, int milliseconds)
5 => AddValues(GetMilliseconds(objectCreationOperation.Arguments[0].Value, DaysToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[1].Value, HoursToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[2].Value, MinutesToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[3].Value, SecondsToMilliseconds),
GetMilliseconds(objectCreationOperation.Arguments[4].Value, 1)),
_ => null,
};
}
}

result += value.GetValueOrDefault();
}
return null;

return result;
static long? AddValues(params ReadOnlySpan<long?> values)
{
var result = 0L;
foreach (var value in values)
{
if (!value.HasValue)
return null;

result += value.GetValueOrDefault();
}

return result;
}
}
}
Loading
Loading