Enable MA0192 by default as suggestion#1172
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 27, 2026
Closed
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
May 27, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.94 to 3.0.96. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.96 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.96> **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.95...3.0.96 ## 3.0.95 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.95> ## What's Changed * Enable MA0192 by default as suggestion by @meziantou in meziantou/Meziantou.Analyzer#1172 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.94...3.0.95 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.94...3.0.96). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 27, 2026
Closed
Closed
Closed
This was referenced May 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MA0192 (
Use HasFlag instead of bitwise checks) was implemented withDiagnosticSeverity.Infobut disabled by default, so it did not show up in the default analyzer configuration. Enabling it by default makes the rule available out of the box as a suggestion.What changed
UseHasFlagMethodAnalyzertoisEnabledByDefault: truefor MA0192.src/Meziantou.Analyzer.Pack/configuration/default.editorconfignow setsdotnet_diagnostic.MA0192.severity = suggestion.README.mdanddocs/README.mdnow show MA0192 as enabled by default.docs/Rules/MA0192.mdconfiguration text to state the rule is enabled by default as a suggestion.Notes
This is a default-configuration and documentation alignment change for MA0192; no rule logic was changed.