Skip to content

Ignore [Experimental] overloads in MA0040 cancellation-token matching#1157

Merged
meziantou merged 2 commits into
mainfrom
copilot/fix-ma0040-experimental-overloads
May 12, 2026
Merged

Ignore [Experimental] overloads in MA0040 cancellation-token matching#1157
meziantou merged 2 commits into
mainfrom
copilot/fix-ma0040-experimental-overloads

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

MA0040/MA0032 currently treats any matching CancellationToken overload as actionable, even when that overload is marked System.Diagnostics.CodeAnalysis.ExperimentalAttribute. This causes false positives by suggesting calls to APIs intentionally gated as experimental.

  • Overload matching behavior

    • Extended OverloadOptions with IncludeExperimentalMembers (default false).
    • Updated OverloadFinder to detect ExperimentalAttribute and skip experimental methods unless explicitly included.
    • Result: MA0040 no longer reports based solely on experimental CancellationToken overloads.
  • Regression coverage

    • Added SuggestOverloadWithExperimentalAttribute in UseAnOverloadThatHasCancellationTokenAnalyzerTests.
    • Test verifies no diagnostic is produced when the only CancellationToken overload is [Experimental].

Example covered by the new behavior:

public static void Method() { }

[Experimental("EXTEXP0001")]
public static void Method(CancellationToken cancellationToken) { }

// MA0040 should not suggest forwarding CT to Method() based only on this experimental overload.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 1s1vsblobprodcus386.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.203/NuGet.Build.Tasks.Console.dll Recursive=False;CleanupAssetsForUnsupportedProjects=True;DisableParallel=False;Force=False;ForceEvaluate=False;HideWarningsAndErrors=False;IgnoreFailedSources=False;Interactive=False;NoCache=False;NoHttpCache=False;RestorePackagesConfig=False /usr/share/dotnet/sdk/10.0.203/MSBuild.dll /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj adFinder.cs (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix MA0040 rule triggering on experimental overloads Ignore [Experimental] overloads in MA0040 cancellation-token matching May 12, 2026
Copilot AI requested a review from meziantou May 12, 2026 21:35
@meziantou meziantou marked this pull request as ready for review May 12, 2026 21:37
@meziantou meziantou enabled auto-merge (squash) May 12, 2026 21:42
@meziantou meziantou merged commit 506e708 into main May 12, 2026
13 checks passed
@meziantou meziantou deleted the copilot/fix-ma0040-experimental-overloads branch May 12, 2026 21:43
This was referenced May 12, 2026
IhateTrains pushed a commit to ParadoxGameConverters/ImperatorToCK3 that referenced this pull request May 13, 2026
Updated
[Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer)
from 3.0.79 to 3.0.84.

<details>
<summary>Release notes</summary>

_Sourced from [Meziantou.Analyzer's
releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._

## 3.0.84

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.84>

## What's Changed
* Ignore `[Experimental]` overloads in MA0040 cancellation-token
matching by @​Copilot in
meziantou/Meziantou.Analyzer#1157


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.83...3.0.84

## 3.0.83

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.83>

## What's Changed
* Add NonAsyncDisposableTypeAttribute for await using by @​meziantou in
meziantou/Meziantou.Analyzer#1154


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.82...3.0.83

## 3.0.82

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.82>

## What's Changed
* Add NonAwaitableTypeAttribute for MA0042/MA0045 by @​meziantou in
meziantou/Meziantou.Analyzer#1153


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.81...3.0.82

## 3.0.81

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.81>

## What's Changed
* Improve annotations documentation and rule references by @​meziantou
in meziantou/Meziantou.Analyzer#1151


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.80...3.0.81

## 3.0.80

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.80>

**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.79...3.0.80

Commits viewable in [compare
view](meziantou/Meziantou.Analyzer@3.0.79...3.0.84).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Meziantou.Analyzer&package-manager=nuget&previous-version=3.0.79&new-version=3.0.84)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MA0040 shouldn't trigger on overloads marked with [Experimental]

2 participants