Extend MA0067 detection for empty Guid patterns#1098
Merged
Conversation
Detect additional empty Guid patterns in MA0067, including constant string constructors, all-zero numeric constructors, and Guid.Parse on constant empty values. Add test coverage for supported formats and non-empty negatives, and update MA0067 documentation examples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 22, 2026
Merged
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Apr 23, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.50 to 3.0.52. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.52 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.52> ## What's Changed * Expand documentation for MA0065, MA0066, and MA0069 by @meziantou in meziantou/Meziantou.Analyzer#1099 * MA0050: improve Throw* argument validation detection by @meziantou in meziantou/Meziantou.Analyzer#1100 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.51...3.0.52 ## 3.0.51 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.51> ## What's Changed * Extend MA0067 detection for empty Guid patterns by @meziantou in meziantou/Meziantou.Analyzer#1098 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.50...3.0.51 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.50...3.0.52). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Apr 23, 2026
Merged
Merged
This was referenced Apr 24, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MA0067 only flagged
new Guid(), so equivalent empty-Guid constructions were missed. This change makes the rule consistently detect empty GUID values regardless of common constructor or parse syntax.What changed
UseGuidEmptyAnalyzerto also report:new Guid("...")when the constant string parses toGuid.Emptynew Guid(0, 0, 0, ...)when all numeric constructor arguments are zeroGuid.Parse("...")when the constant string parses toGuid.EmptyNumericHelpers.IsZerofor numeric zero checks.UseGuidEmptyAnalyzerTestswith positive and negative cases, including multiple supported empty-Guid string formats (dashed, braced, parenthesized, and no-dash).Notes
Guid.TryParse, so it naturally supports all formats accepted by the BCL parser.