Fix MA0135/MA0139: Serilog @ destructuring prefix not stripped consistently for multi-parameter log calls

[Copilot]

MA0135/MA0139 inconsistently stripped the Serilog @ destructuring prefix depending on the number of log arguments. With a single argument, {@foo} was correctly resolved to foo in LoggerParameterTypes.txt. With multiple arguments, stripping was skipped, requiring @foo in the config instead — contradicting the single-argument behavior.

// Single param: analyzer strips @, expects "foo" in config ✓
logger.Debug("{@foo}", new object());

// Multiple params: analyzer did NOT strip @, expected "@foo" in config ✗
logger.Debug("{@foo}, {@tar}", new object(), new object());

// Mixed: also did NOT strip @, expected "@foo" ✗
logger.Debug("{bar}, {@foo}", 123, new object());

Root cause: potentialNamePrefixes = SerilogPrefixes was set inside the if (arguments.Length == templateIndex + 2) guard, which only matches when there is exactly one argument after the message template (the params-array overload case). Typed generic overloads with 2+ arguments bypassed it entirely.

Fix: Move potentialNamePrefixes = SerilogPrefixes unconditionally into the Serilog branch, outside the single-argument guard. The @/$ prefix is now always stripped for Serilog log method calls regardless of argument count. LoggerParameterTypes.txt entries should always be written without the @ prefix (e.g. foo;System.Object, not @foo;System.Object).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• 1s1vsblobprodcus386.vsblob.vsassets.io
  • Triggering command: /usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)
• pdfvsblobprodcus380.vsblob.vsassets.io
  • Triggering command: /usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)
• st8vsblobprodcus339.vsblob.vsassets.io
  • Triggering command: /usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)