Skip to content

MA0011: suppress diagnostic when all AppendFormat template arguments are culture-insensitive #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 2 commits into from
Apr 2, 2026
Merged

MA0011: suppress diagnostic when all AppendFormat template arguments are culture-insensitive #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
915fa4e
Initial plan
Copilot Apr 2, 2026
3e9dfa5
Fix MA0011: do not report when all AppendFormat template arguments ar…
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/Meziantou.Analyzer/Internals/CultureSensitiveFormattingContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,30 @@ public bool IsCultureSensitiveOperation(IOperation operation, CultureSensitiveOp
if (invocation.Arguments.Length == 1 && invocation.Arguments[0].Value.Type.IsEqualTo(StringBuilder_AppendInterpolatedStringHandlerSymbol) && !IsCultureSensitiveOperation(invocation.Arguments[0].Value, options))
return false;
}
else if (methodName is "AppendFormat" && invocation.TargetMethod.ContainingType.IsEqualTo(StringBuilderSymbol) && invocation.Arguments.Length > 0)
{
if (invocation.Arguments.Length == 1)
return false;

if (invocation.TargetMethod.Parameters.Length == 2 && invocation.Arguments[1].Parameter?.Type is IArrayTypeSymbol && invocation.Arguments[1].Value is IArrayCreationOperation appendFormatArrayCreation)
{
var initializer = appendFormatArrayCreation.Initializer;
if (initializer is null)
return true;

return initializer.ElementValues.Any(arg => IsCultureSensitiveOperation(arg.UnwrapImplicitConversionOperations(), options));
}
#if ROSLYN_4_14_OR_GREATER
else if (invocation.TargetMethod.Parameters.Length == 2 && invocation.Arguments[1].Value is ICollectionExpressionOperation appendFormatCollectionExpression)
{
return appendFormatCollectionExpression.Elements.Any(arg => IsCultureSensitiveOperation(arg.UnwrapImplicitConversionOperations(), options));
}
#endif
else
{
return invocation.Arguments.Skip(1).Any(arg => IsCultureSensitiveOperation(arg.Value.UnwrapImplicitConversionOperations(), options));
}
}
else if (methodName is "Format" && invocation.TargetMethod.IsStatic && invocation.TargetMethod.ContainingType.IsString() && invocation.Arguments.Length > 0)
{
if (invocation.TargetMethod.Parameters[0].Type.IsEqualTo(FormatProviderSymbol))
Expand Down
4 changes: 3 additions & 1 deletion tests/Meziantou.Analyzer.Test/Rules/UseIFormatProviderAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ await CreateProjectBuilder()
[InlineData(""" [|System.DateTime.TryParse("", out _)|] """)]
[InlineData(""" [|System.DateTimeOffset.TryParse("", out _)|] """)]
[InlineData(""" [|"".ToLower()|] """)]
[InlineData(""" [|new System.Text.StringBuilder().AppendFormat("{0}", 10)|] """)]
[InlineData(""" [|new System.Text.StringBuilder().AppendFormat("{0}", -1)|] """)]
[InlineData(""" new System.Text.StringBuilder().AppendFormat("{0}", 10) """)]
[InlineData(""" new System.Text.StringBuilder().AppendFormat("{0} / {1}", "X", "Y") """)]
[InlineData(""" System.DayOfWeek.Monday.ToString() """)]
[InlineData(""" default(System.DateTime).ToString("o") """)]
[InlineData(""" default(System.DateTime).ToString("O") """)]
Expand Down
Loading