Add code fixers for MA0138/44/46/52/56/57/58/60/69/73#1074
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 31, 2026
Closed
Closed
Closed
This was referenced Apr 2, 2026
Merged
IhateTrains
added a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Apr 3, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.29 to 3.0.44. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.44 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.44> ## What's Changed * MA0011: suppress diagnostic when all AppendFormat template arguments are culture-insensitive by @Copilot in meziantou/Meziantou.Analyzer#1085 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.43...3.0.44 ## 3.0.43 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.43> ## What's Changed * Fix expression parenthesis in code fixers by @meziantou in meziantou/Meziantou.Analyzer#1083 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.42...3.0.43 ## 3.0.42 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.42> ## What's Changed * Cache IsAwaitable result for the no-SyntaxNode overload by @meziantou in meziantou/Meziantou.Analyzer#1082 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.41...3.0.42 ## 3.0.41 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.41> ## What's Changed * Improve MA0042 async overload matching coverage by @meziantou in meziantou/Meziantou.Analyzer#1065 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.40...3.0.41 ## 3.0.40 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.40> ## What's Changed * Add MA0191: Detect null! and default! usage by @Copilot in meziantou/Meziantou.Analyzer#1081 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.39...3.0.40 ## 3.0.39 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.39> ## What's Changed * Add code fixes for MA0094-MA0097 by @meziantou in meziantou/Meziantou.Analyzer#1078 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.38...3.0.39 ## 3.0.38 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.38> ## What's Changed * Fix typos and grammar across all 188 rule documentation files by @Copilot in meziantou/Meziantou.Analyzer#1076 * Add code fixers for MA0118, MA0161, and MA0186 by @meziantou in meziantou/Meziantou.Analyzer#1079 * Validate fix conditions in RegisterCodeFixesAsync before registering code fixes by @Copilot in meziantou/Meziantou.Analyzer#1077 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.37...3.0.38 ## 3.0.37 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.37> ## What's Changed * docs: require updating rule docs when rules change by @meziantou in meziantou/Meziantou.Analyzer#1075 * Add code fixers for MA0138/44/46/52/56/57/58/60/69/73 by @meziantou in meziantou/Meziantou.Analyzer#1074 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.36...3.0.37 ## 3.0.36 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.36> ## What's Changed * Add missing code fixers for 10 analyzer rules by @meziantou in meziantou/Meziantou.Analyzer#1073 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.35...3.0.36 ## 3.0.35 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.35> ## What's Changed * Add missing code fixers for MA0088-MA0137 by @meziantou in meziantou/Meziantou.Analyzer#1072 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.34...3.0.35 ## 3.0.34 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.34> ## What's Changed * Add code fixer for MA0174 (Record should use explicit 'class' keyword) by @Copilot in meziantou/Meziantou.Analyzer#1070 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.33...3.0.34 ## 3.0.33 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.33> ## What's Changed * Add code fixer for MA0173 (Use LazyInitializer.EnsureInitialized) by @Copilot in meziantou/Meziantou.Analyzer#1071 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.32...3.0.33 ## 3.0.32 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.32> ## What's Changed * Add code fixer for MA0175 (Remove explicit `class` keyword from record declarations) by @Copilot in meziantou/Meziantou.Analyzer#1069 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.31...3.0.32 ## 3.0.31 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.31> ## What's Changed * Add code fixer for MA0137 and MA0138 (async suffix naming) by @Copilot in meziantou/Meziantou.Analyzer#1068 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.30...3.0.31 ## 3.0.30 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.30> ## What's Changed * MA0137: Add `exclude_test_methods` configuration option by @Copilot in meziantou/Meziantou.Analyzer#1067 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.29...3.0.30 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.29...3.0.44). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Apr 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several rules in this range were reported as lacking code fixers, which made adoption harder and left straightforward remediations manual.
This PR adds and validates code fixes for the requested MA rules so diagnostics are actionable directly from IDE/lightbulb workflows.
What changed
MA0144(UseOperatingSystemInsteadOfRuntimeInformationFixer)MA0146(ValidateUnsafeAccessorAttributeUsageFixer)MA0152(UseTaskUnwrapFixer)MA0158(UseSystemThreadingLockInsteadOfObjectFixer)MA0160(UseContainsKeyInsteadOfTryGetValueFixer)MA0169(UseEqualsMethodInsteadOfOperatorFixer)MA0156andMA0157MA0138,MA0173) and validated them in the updated targeted suite.Tests and validation
MethodsReturningAnAwaitableTypeMustHaveTheAsyncSuffixAnalyzerTestsUseOperatingSystemInsteadOfRuntimeInformationAnalyzerTestsValidateUnsafeAccessorAttributeUsageAnalyzerTestsUseTaskUnwrapAnalyzerTestsUseSystemThreadingLockInsteadOfObjectAnalyzerTestsUseContainsKeyInsteadOfTryGetValueAnalyzerTestsUseEqualsMethodInsteadOfOperatorAnalyzerTests89/89).Documentation
dotnet run --project src/DocumentationGeneratorand included generated updates.README.mddocs/README.mddocs/Rules/MA*.mdfiles.Notes for reviewers
Name = "..."on[UnsafeAccessor]local-function attributes and now explicitly handles nested local functions in method bodies.objectlock symbol declarations/usages toSystem.Threading.Lockand normalizesnew object()initializers tonew()for the migrated lock type.