Add MA0188: Use System.TimeProvider instead of a custom time abstraction#1055
Merged
Add MA0188: Use System.TimeProvider instead of a custom time abstraction#1055
Conversation
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add rule to check for specific time-related interfaces
Add MA0188: Use System.TimeProvider instead of a custom time abstraction
Mar 9, 2026
meziantou
reviewed
Mar 9, 2026
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
meziantou
reviewed
Mar 9, 2026
meziantou
reviewed
Mar 9, 2026
… docs Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
meziantou
reviewed
Mar 9, 2026
meziantou
reviewed
Mar 9, 2026
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
…et null checks Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
meziantou
reviewed
Mar 9, 2026
Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
This was referenced Apr 7, 2026
Closed
This was referenced Apr 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UseTimeProviderInsteadOfInterface = "MA0188"toRuleIdentifiers.csUseTimeProviderInsteadOfInterfaceAnalyzer.csanalyzer (enabled by default, DiagnosticSeverity.Info)docs/Rules/MA0188.mddocumentationUseTimeProviderInsteadOfInterfaceAnalyzerTests.cs(14 tests, all passing)dotnet run --project src/DocumentationGeneratorto update generated docshasAtLeastOneTimeMembertrackingNow,UtcNow,GetNow,GetUtcNow,CurrentTimeCurrentTimenow reports a diagnostic; test updated accordinglyMicrosoft.Bcl.TimeProviderNuGet package in docs for older TFM supportisEnabledByDefault: true)IsDateTimeOrDateTimeOffset— rely onIsEqualTo's built-in null handlingdocs/Rules/MA0188.md💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.