Skip to content

Fix IDE0330 comparison incorrectly referencing MA0153 instead of MA0158#1036

Merged
meziantou merged 2 commits intomainfrom
copilot/update-documentation-for-ma0158
Feb 22, 2026
Merged

Fix IDE0330 comparison incorrectly referencing MA0153 instead of MA0158#1036
meziantou merged 2 commits intomainfrom
copilot/update-documentation-for-ma0158

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 22, 2026

The comparison-with-other-analyzers doc mapped IDE0330 ("Prefer System.Threading.Lock") to MA0153 ("Do not log symbols decorated with DataClassificationAttribute directly") — a completely unrelated rule. The correct equivalent is MA0158 ("Use System.Threading.Lock").

Changes

  • docs/comparison-with-other-analyzers.md: Replace MA0153 with MA0158 in the IDE0330 row of the Similar rules table
Original prompt

This section details on the original issue you should resolve

<issue_title>MA0153 is wrongly listed as similar to IDE0330</issue_title>
<issue_description>### Version of the Meziantou.Analyzer NuGet package

3.0.10

Rule Identifier

MA0153

Target Framework

.NET 10.0

C# Language version

C# 14

Description

MA0153 (Do not log symbols decorated with DataClassificationAttribute directly) is currently documented as being similar to IDE0330 (Prefer 'System.Threading.Lock').

This surely should have been another MS analyzer rule.
</issue_description>

<agent_instructions>Can you upate the documentation to mention MA0158 instead of MA0153</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copilot AI changed the title [WIP] Update documentation to reference MA0158 instead of MA0153 Fix IDE0330 comparison incorrectly referencing MA0153 instead of MA0158 Feb 22, 2026
Copilot AI requested a review from meziantou February 22, 2026 15:26
@meziantou meziantou marked this pull request as ready for review February 22, 2026 15:28
@meziantou meziantou enabled auto-merge (squash) February 22, 2026 15:28
@meziantou meziantou merged commit acab137 into main Feb 22, 2026
12 checks passed
@meziantou meziantou deleted the copilot/update-documentation-for-ma0158 branch February 22, 2026 15:32
This was referenced Feb 22, 2026
This was referenced May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MA0153 is wrongly listed as similar to IDE0330

2 participants