Skip to content

MA0110: Suggest partial property before partial method #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 6 commits into from
Feb 19, 2026
Merged

MA0110: Suggest partial property before partial method #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99cd7b3
Initial plan
Copilot Feb 19, 2026
aea99d5
Swap order of MA0110 code fixes (property before method)
Copilot Feb 19, 2026
53a396e
Add conditional index to partial method tests
Copilot Feb 19, 2026
e0e9a40
Fix CI test failures by using explicit C# 11 language version for par…
Copilot Feb 19, 2026
c630f40
Fix syntax error in language version cast
Copilot Feb 19, 2026
ff636df
Use enum CSharp11 with conditional compilation instead of numeric cast
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/Meziantou.Analyzer.CodeFixers/Rules/UseRegexSourceGeneratorFixer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
isCSharp14OrAbove = parseOptions.LanguageVersion.IsCSharp14OrAbove();
}

// Always offer partial method
context.RegisterCodeFix(
CodeAction.Create(
"Use Regex Source Generator (partial method)",
cancellationToken => ConvertToSourceGenerator(context.Document, context.Diagnostics[0], usePartialProperty: false, cancellationToken),
equivalenceKey: "Use Regex Source Generator (partial method)"),
context.Diagnostics);

// Offer partial property if C# 14 or later
// Offer partial property first if C# 14 or later
if (isCSharp14OrAbove)
{
context.RegisterCodeFix(
Expand All @@ -56,6 +48,14 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
equivalenceKey: "Use Regex Source Generator (partial property)"),
context.Diagnostics);
}

// Always offer partial method
context.RegisterCodeFix(
CodeAction.Create(
"Use Regex Source Generator (partial method)",
cancellationToken => ConvertToSourceGenerator(context.Document, context.Diagnostics[0], usePartialProperty: false, cancellationToken),
equivalenceKey: "Use Regex Source Generator (partial method)"),
context.Diagnostics);
}

private static async Task<Document> ConvertToSourceGenerator(Document document, Diagnostic diagnostic, bool usePartialProperty, CancellationToken cancellationToken)
Expand Down
Loading